[FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

[FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

[Ramiro Polla]

---
 libswscale/x86/yuv_2_rgb.asm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm
index e3470fd9ad..a1f9134e08 100644
--- a/libswscale/x86/yuv_2_rgb.asm
+++ b/libswscale/x86/yuv_2_rgb.asm
@@ -195,15 +195,15 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
     mova m5, m7
     paddsw m3, m0 ; B1 B3 B5 B7 ...
     paddsw m5, m1 ; R1 R3 R5 R7 ...
-    paddsw m7, m2 ; G1 G3 G4 G7 ...
+    paddsw m7, m2 ; G1 G3 G5 G7 ...
     paddsw m0, m6 ; B0 B2 B4 B6 ...
     paddsw m1, m6 ; R0 R2 R4 R6 ...
     paddsw m2, m6 ; G0 G2 G4 G6 ...
 
 %if %3 == 24 ; PACK RGB24
 %define depth 3
-    packuswb m0, m3 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
-    packuswb m1, m5 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
+    packuswb m0, m3 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
+    packuswb m1, m5 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
     packuswb m2, m7 ; G0 G2 G4 G6 ... G1 G3 G5 G7 ...
     mova m3, m_red
     mova m6, m_blue
@@ -248,7 +248,7 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
     psrlq m5, 32
     movd [imageq + 20], m2 ; -- -- G7 B7
     movd [imageq + 18], m5 ; R6 G6 B6 R7
-%endif ; mmsize = 8
+%endif ; cpuflag
 %else ; mmsize == 16
     pshufb m3, [rgb24_shuf1] ; r0  g0  r6  g6  r12 g12 r2  g2  r8  g8  r14 g14 r4  g4  r10 g10
     pshufb m6, [rgb24_shuf2] ; b10 r11 b0  r1  b6  r7  b12 r13 b2  r3  b8  r9  b14 r15 b4  r5
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

[Ramiro Polla]

On Tue, Jun 4, 2024 at 3:15 PM Ramiro Polla <ramiro.polla@gmail.com> wrote:
>
> ---
>  libswscale/x86/yuv_2_rgb.asm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm
> index e3470fd9ad..a1f9134e08 100644
> --- a/libswscale/x86/yuv_2_rgb.asm
> +++ b/libswscale/x86/yuv_2_rgb.asm
> @@ -195,15 +195,15 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
>      mova m5, m7
>      paddsw m3, m0 ; B1 B3 B5 B7 ...
>      paddsw m5, m1 ; R1 R3 R5 R7 ...
> -    paddsw m7, m2 ; G1 G3 G4 G7 ...
> +    paddsw m7, m2 ; G1 G3 G5 G7 ...
>      paddsw m0, m6 ; B0 B2 B4 B6 ...
>      paddsw m1, m6 ; R0 R2 R4 R6 ...
>      paddsw m2, m6 ; G0 G2 G4 G6 ...
>
>  %if %3 == 24 ; PACK RGB24
>  %define depth 3
> -    packuswb m0, m3 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
> -    packuswb m1, m5 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
> +    packuswb m0, m3 ; B0 B2 B4 B6 ... B1 B3 B5 B7 ...
> +    packuswb m1, m5 ; R0 R2 R4 R6 ... R1 R3 R5 R7 ...
>      packuswb m2, m7 ; G0 G2 G4 G6 ... G1 G3 G5 G7 ...
>      mova m3, m_red
>      mova m6, m_blue
> @@ -248,7 +248,7 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters
>      psrlq m5, 32
>      movd [imageq + 20], m2 ; -- -- G7 B7
>      movd [imageq + 18], m5 ; R6 G6 B6 R7
> -%endif ; mmsize = 8
> +%endif ; cpuflag
>  %else ; mmsize == 16
>      pshufb m3, [rgb24_shuf1] ; r0  g0  r6  g6  r12 g12 r2  g2  r8  g8  r14 g14 r4  g4  r10 g10
>      pshufb m6, [rgb24_shuf2] ; b10 r11 b0  r1  b6  r7  b12 r13 b2  r3  b8  r9  b14 r15 b4  r5
> --
> 2.30.2
>

I'll apply tomorrow.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".