[FFmpeg-devel] [PATCH] codec_desc: drop INTRA_ONLY flag for AAC

[FFmpeg-devel] [PATCH] codec_desc: drop INTRA_ONLY flag for AAC

[Lynne via ffmpeg-devel]

Not valid anymore with xHE-AAC.
---
 libavcodec/codec_desc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index a28ef68061..a3b983b907 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/codec_desc.c
@@ -2697,7 +2697,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
         .type      = AVMEDIA_TYPE_AUDIO,
         .name      = "aac",
         .long_name = NULL_IF_CONFIG_SMALL("AAC (Advanced Audio Coding)"),
-        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSY,
+        .props     = AV_CODEC_PROP_LOSSY,
         .profiles  = NULL_IF_CONFIG_SMALL(ff_aac_profiles),
     },
     {
@@ -3031,7 +3031,7 @@ static const AVCodecDescriptor codec_descriptors[] = {
         .type      = AVMEDIA_TYPE_AUDIO,
         .name      = "aac_latm",
         .long_name = NULL_IF_CONFIG_SMALL("AAC LATM (Advanced Audio Coding LATM syntax)"),
-        .props     = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSY,
+        .props     = AV_CODEC_PROP_LOSSY,
         .profiles  = NULL_IF_CONFIG_SMALL(ff_aac_profiles),
     },
     {
-- 
2.43.0.381.gb435a96ce8
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] codec_desc: drop INTRA_ONLY flag for AAC

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1252 bytes --]

On Sun, Jun 02, 2024 at 07:15:54PM +0200, Lynne via ffmpeg-devel wrote:
> Not valid anymore with xHE-AAC.
> ---
>  libavcodec/codec_desc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

breaks fate

--- ./tests/ref/fate/mkv	2024-06-03 22:55:42.149081056 +0200
+++ tests/data/fate/mkv	2024-06-04 02:21:45.904176579 +0200
@@ -13,215 +13,215 @@
 0,        -42,          0,       41,    63501, 0x139d4c99
 0,          0,         84,       41,     5368, 0xd964b678, F=0x0
 1,          8,          8,       21,      528, 0x3c990ddf
-1,         29,         29,       21,      510, 0xc16e0719
+1,         29,         29,       21,      510, 0xc16e0719, F=0x0
 0,         42,         42,       41,     1840, 0x097b6726, F=0x0
-1,         50,         50,       21,      500, 0x6248f603
-1,         71,         71,       22,      491, 0xe767f705
+1,         50,         50,       21,      500, 0x6248f603, F=0x0
+1,         71,         71,       22,      491, 0xe767f705, F=0x0
 0,         84,        167,       41,     7168, 0xaa5913ed, F=0x0

...

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".