From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F0A054B327 for ; Mon, 3 Jun 2024 22:42:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9DB1C68D6AB; Tue, 4 Jun 2024 01:42:10 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E70AD68D2E0 for ; Tue, 4 Jun 2024 01:42:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4027DC0006 for ; Mon, 3 Jun 2024 22:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717454523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HXBpRomgr5Pac3xcJrDD/SrwozbUZE6bSV6WoWDddk8=; b=ISTub3hqBBqsEyOTqe8pchTD2XAPoF3KR7ZP1uXkScsQ8ezeZLvNCv5zDpcqbZ7fDeoi7b tuFWAZCCKNOD/yIQ9MFE9pCYaEuSkTRuAmKC9GkqzO5ItTkSvw/OGcM3sHbNLqtsH61Z3j vG7qp64yjcIZNyQ/PHISwC1tpp+Kjt3UFLgSIJLN/pkXrh2uL4DuUbjQFDSkDwJX8/R7KC ECqxK9IFg/e95KEpDVAZy2zO8y91Mjlhx5MrEpImmsSYZ6v8N/jibwjN2yPPQHXoXeMOKX zqEB8Je8ln5FW/lJtlXdgfwW5tskcYfkfKphl6vqrNOWX9INoMIM4AChsuwyZg== Date: Tue, 4 Jun 2024 00:42:02 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240603224202.GD2821752@pb2> References: <000c01daa54d$8a0eedf0$9e2cc9d0$@gmail.com> <20240530213132.GE2821752@pb2> <008e01dab529$e5510630$aff31290$@gmail.com> MIME-Version: 1.0 In-Reply-To: <008e01dab529$e5510630$aff31290$@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] area changed: scdet filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3446854505486519669==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3446854505486519669== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rOnZ5ITIX7GHaQD9" Content-Disposition: inline --rOnZ5ITIX7GHaQD9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 02, 2024 at 11:17:29PM +0300, radu.taraibuta@gmail.com wrote: >=20 >=20 > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: vineri, 31 mai 2024 00:32 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] area changed: scdet filter > >=20 > > On Mon, May 13, 2024 at 06:52:19PM +0300, radu.taraibuta@gmail.com > > wrote: > > > Previous observations: > > > > > > - Inconsistent code style with other filters. (Mostly using > > > AVFilterLink* link instead of AVFilterLink *link). > > > I hope it's fine now. > > > > > > - Unrelated changes, please split trivial unrelated changes into > > > separate patches. > > > Removed trivial changes from this patch. > > > > > > - Can't tables be generated at .init/.config_props time? No point in > > > storing them into binary. > > > Done. > > > > > > - Adding extra delay is not backward compatible change, it should be > > > implemented properly by adding option for users to select mode: next & > > > prev frame or just next or prev frame. > > > Added legacy option to the mode parameter. > > > > > > - Could split frame clone change into earlier separate patch. > > > Cannot be done. It's either frame clone or 1 frame delay. > > > > > > - Where are results of improvements with accuracy so it can be > confirmed? > > > Here are my test results with manual labeling of scene changes: > > > 2379 Full length movie > > > > > > Method Threshold TP FP FN Precision > > > Recall F > > > Cubic 7 2357 423 22 0.847841727 > 0.990752417 > > > 0.913742973 > > > Cubic 10 2297 200 82 0.919903885 > 0.965531736 > > > 0.94216571 > > > Cubic 12 2217 146 162 0.938214135 > 0.931904161 > > > 0.935048503 > > > Cubic 15 2049 101 330 0.953023256 > 0.861286255 > > > 0.904835505 > > > Linear 2.8 2357 1060 22 0.689786362 > 0.990752417 > > > 0.813319531 > > > Linear 8 2099 236 280 0.898929336 > 0.882303489 > > > 0.890538821 > > > Linear 10 1886 173 493 0.91597863 > 0.792770071 > > > 0.849932402 > > > Legacy 5 2235 1260 144 0.639484979 > > 0.939470366 > > > 0.760980592 > > > Legacy 8 1998 414 381 0.828358209 > > 0.839848676 > > > 0.83406387 > > > Legacy 10 1743 193 636 0.900309917 > > 0.732660782 > > > 0.80787949 > > > > > > 15 HDR10Plus_PB_EAC3JOC > > > https://mega.nz/file/nehDka6Z#C5_OPbSZkONdOp1jRmc09C9- > > viDc3zMj8ZHruHcW > > > KyA > > > > > > Method Threshold TP FP FN Precision > > > Recall F > > > Cubic 10 15 0 0 1 1 1 > > > Linear 5 13 1 2 0.928571429 > 0.866666667 > > > 0.896551724 > > > Legacy 5 12 2 3 0.857142857 0.8 > > > 0.827586207 > > > > > > 21 (HDR HEVC 10-bit BT.2020 24fps) Exodus Sample > > > > > https://mega.nz/file/Sfw1hDpK#ErxCOpQDVjcI1gq6ZbX3vIfdtXZompkFe0jq47E > > h > > > R2o > > > > > > Method Threshold TP FP FN Precision > > > Recall F > > > Cubic 10 21 0 0 1 1 1 > > > Linear 4 20 0 1 1 0.952380952 > > > 0.975609756 > > > Legacy 4 19 0 2 1 0.904761905 > > 0.95 > > > > > > 94 Bieber Grammys > > > https://mega.nz/#!c9dhAaKA!MG5Yi- > > MJNATE2_KqcnNJZCRKtTWvdjJP1NwG8Ggdw3E > > > > > > Method Threshold TP FP FN Precision > > > Recall F > > > Cubic 15 91 23 3 0.798245614 > 0.968085106 > > > 0.875 > > > Cubic 18 85 9 9 0.904255319 > 0.904255319 > > > 0.904255319 > > > Linear 7 79 49 15 0.6171875 > 0.840425532 > > > 0.711711712 > > > Linear 8 74 28 20 0.725490196 > 0.787234043 > > > 0.755102041 > > > Legacy 7 74 40 20 0.649122807 > > 0.787234043 > > > 0.711538462 > > > Legacy 8 71 26 23 0.731958763 > > 0.755319149 > > > 0.743455497 > > > > > > > > > Improve scene detection accuracy by comparing frame with both previous > > > and next frame (creates one frame delay). > > > Add new mode parameter and new method to compute the frame difference > > > using cubic square to increase the weight of small changes and new me= an > > formula. > > > This improves accuracy significantly. Slightly improve performance by > > > not using frame clone. > > > Add legacy mode for backward compatibility. > > > > > > Signed-off-by: raduct > > > --- > > > doc/filters.texi | 16 ++++ > > > libavfilter/scene_sad.c | 151 ++++++++++++++++++++++++++++++++++ > > > libavfilter/scene_sad.h | 6 ++ > > > libavfilter/vf_scdet.c | 156 +++++++++++++++++++++++++---------= -- > > > tests/fate/filter-video.mak | 3 + > > > 5 files changed, 284 insertions(+), 48 deletions(-) > > > > > > diff --git a/doc/filters.texi b/doc/filters.texi index > > > bfa8ccec8b..53814e003b 100644 > > > --- a/doc/filters.texi > > > +++ b/doc/filters.texi > > > @@ -21797,6 +21797,22 @@ Default value is @code{10.}. > > > @item sc_pass, s > > > Set the flag to pass scene change frames to the next filter. Default > > > value is @code{0} > >=20 > > The patch is corrupted by linebreaks: > >=20 > > Applying: area changed: scdet filter > > error: corrupt patch at line 16 > > Patch failed at 0001 area changed: scdet filter > >=20 > > please check the linebreak settings or attach the patch or use git > send-email > >=20 > > thx > >=20 > > [...] > > -- > > Michael GnuPG fingerprint: > > 9FF2128B147EF6730BADF133611EC787040B0FAB > >=20 > > Homeopathy is like voting while filling the ballot out with transparent > ink. > > Sometimes the outcome one wanted occurs. Rarely its worse than filling = out > a > > ballot properly. >=20 > Please find attached the patch. >=20 > doc/filters.texi | 16 ++++ > libavfilter/scene_sad.c | 151 +++++++++++++++++++++++++++++++++++++= +++++ > libavfilter/scene_sad.h | 6 + > libavfilter/vf_scdet.c | 156 ++++++++++++++++++++++++++++++-------= ------- > tests/fate/filter-video.mak | 3=20 > 5 files changed, 284 insertions(+), 48 deletions(-) > 8f29f2e1c202ab283a9ca0f5d9599de6ab534d7a 0001-area-changed-scdet-filter.= patch > From 6d55c65d92376b0ab6e3bb2439af30fbcc430d0b Mon Sep 17 00:00:00 2001 > From: raduct > Date: Wed, 8 May 2024 08:24:46 +0300 > Subject: [PATCH] area changed: scdet filter >=20 > Improve scene detection accuracy by comparing frame with both previous an= d next frame (creates one frame delay). > Add new mode parameter and new method to compute the frame difference usi= ng cubic square to increase the weight of small changes and new mean formul= a. This improves accuracy significantly. Slightly improve performance by no= t using frame clone. > Add legacy mode for backward compatibility. >=20 > Signed-off-by: raduct > --- > doc/filters.texi | 16 ++++ > libavfilter/scene_sad.c | 151 ++++++++++++++++++++++++++++++++++ > libavfilter/scene_sad.h | 6 ++ > libavfilter/vf_scdet.c | 156 +++++++++++++++++++++++++----------- > tests/fate/filter-video.mak | 3 + > 5 files changed, 284 insertions(+), 48 deletions(-) fails to build libavfilter/scene_sad.c: In function =E2=80=98ff_init_cbrt=E2=80=99: libavfilter/scene_sad.c:86:5: warning: ISO C90 forbids mixed declarations a= nd code [-Wdeclaration-after-statement] 86 | uint8_t *table =3D cbrt_table[bitdepth]; | ^~~~~~~ libavfilter/scene_sad.c:92:13: error: implicit declaration of function =E2= =80=98av_malloc=E2=80=99; did you mean =E2=80=98malloc=E2=80=99? [-Werror= =3Dimplicit-function-declaration] 92 | table =3D av_malloc((1 << bitdepth) * (bitdepth > 8 ? 2 : 1)); | ^~~~~~~~~ | malloc libavfilter/scene_sad.c:92:11: warning: assignment to =E2=80=98uint8_t *=E2= =80=99 {aka =E2=80=98unsigned char *=E2=80=99} from =E2=80=98int=E2=80=99 m= akes pointer from integer without a cast [-Wint-conversion] 92 | table =3D av_malloc((1 << bitdepth) * (bitdepth > 8 ? 2 : 1)); | ^ libavfilter/scene_sad.c:98:5: warning: ISO C90 forbids mixed declarations a= nd code [-Wdeclaration-after-statement] 98 | int size =3D 1 << bitdepth; | ^~~ libavfilter/scene_sad.c: In function =E2=80=98ff_uninit_cbrt=E2=80=99: libavfilter/scene_sad.c:120:9: error: implicit declaration of function =E2= =80=98av_free=E2=80=99; did you mean =E2=80=98free=E2=80=99? [-Werror=3Dimp= licit-function-declaration] 120 | av_free(cbrt_table[bitdepth]); | ^~~~~~~ | free libavfilter/scene_sad.c: At top level: libavfilter/scene_sad.c:126:6: error: no previous prototype for =E2=80=98ff= _scene_scrd_c=E2=80=99 [-Werror=3Dmissing-prototypes] 126 | void ff_scene_scrd_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~ libavfilter/scene_sad.c: In function =E2=80=98ff_scene_scrd_c=E2=80=99: libavfilter/scene_sad.c:148:5: warning: ISO C90 forbids mixed declarations = and code [-Wdeclaration-after-statement] 148 | double mean =3D (sqrt(scrdPlus) + sqrt(scrdMinus)) / 2.0; | ^~~~~~ libavfilter/scene_sad.c: At top level: libavfilter/scene_sad.c:152:6: error: no previous prototype for =E2=80=98ff= _scene_scrd2B_c=E2=80=99 [-Werror=3Dmissing-prototypes] 152 | void ff_scene_scrd2B_c(SCENE_SAD_PARAMS, int bitdepth) | ^~~~~~~~~~~~~~~~~ libavfilter/scene_sad.c: In function =E2=80=98ff_scene_scrd2B_c=E2=80=99: libavfilter/scene_sad.c:179:5: warning: ISO C90 forbids mixed declarations = and code [-Wdeclaration-after-statement] 179 | double mean =3D (sqrt(scrdPlus) + sqrt(scrdMinus)) / 2.0; | ^~~~~~ libavfilter/scene_sad.c: At top level: libavfilter/scene_sad.c:183:6: error: no previous prototype for =E2=80=98ff= _scene_scrd9_c=E2=80=99 [-Werror=3Dmissing-prototypes] 183 | void ff_scene_scrd9_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~~ libavfilter/scene_sad.c:188:6: error: no previous prototype for =E2=80=98ff= _scene_scrd10_c=E2=80=99 [-Werror=3Dmissing-prototypes] 188 | void ff_scene_scrd10_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~~~ libavfilter/scene_sad.c:193:6: error: no previous prototype for =E2=80=98ff= _scene_scrd12_c=E2=80=99 [-Werror=3Dmissing-prototypes] 193 | void ff_scene_scrd12_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~~~ libavfilter/scene_sad.c:198:6: error: no previous prototype for =E2=80=98ff= _scene_scrd14_c=E2=80=99 [-Werror=3Dmissing-prototypes] 198 | void ff_scene_scrd14_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~~~ libavfilter/scene_sad.c:203:6: error: no previous prototype for =E2=80=98ff= _scene_scrd16_c=E2=80=99 [-Werror=3Dmissing-prototypes] 203 | void ff_scene_scrd16_c(SCENE_SAD_PARAMS) | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make: *** [ffbuild/common.mak:81: libavfilter/scene_sad.o] Error 1 make: *** Waiting for unfinished jobs.... [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. U= ser questions about the command line tools should be sent to the ffmpeg-user ML. And questions about how to use libav* should be sent to the libav-user ML. --rOnZ5ITIX7GHaQD9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZl5GtwAKCRBhHseHBAsP q/gvAJ95s+O70qEUm/mw5NDKZ22Be+8w6QCglE+oJ2TIRPubRL7Q0sDz5qNMVCo= =pP1O -----END PGP SIGNATURE----- --rOnZ5ITIX7GHaQD9-- --===============3446854505486519669== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3446854505486519669==--