From: tong1.wu-at-intel.com@ffmpeg.org
To: ffmpeg-devel@ffmpeg.org
Cc: Tong Wu <tong1.wu@intel.com>
Subject: [FFmpeg-devel] [PATCH v13 05/15] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc
Date: Mon, 3 Jun 2024 17:18:58 +0800
Message-ID: <20240603091909.1161-5-tong1.wu@intel.com> (raw)
In-Reply-To: <20240603091909.1161-1-tong1.wu@intel.com>
From: Tong Wu <tong1.wu@intel.com>
When allocating the VAAPIEncodePicture, pic->input_surface can be
initialized right in the place. This movement simplifies the send_frame
logic and is the preparation for moving vaapi_encode_send_frame to the base layer.
Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
libavcodec/vaapi_encode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index 54bdd73902..194422b36d 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@ -878,7 +878,8 @@ static int vaapi_encode_discard(AVCodecContext *avctx,
return 0;
}
-static VAAPIEncodePicture *vaapi_encode_alloc(AVCodecContext *avctx)
+static VAAPIEncodePicture *vaapi_encode_alloc(AVCodecContext *avctx,
+ const AVFrame *frame)
{
VAAPIEncodeContext *ctx = avctx->priv_data;
VAAPIEncodePicture *pic;
@@ -895,7 +896,7 @@ static VAAPIEncodePicture *vaapi_encode_alloc(AVCodecContext *avctx)
}
}
- pic->input_surface = VA_INVALID_ID;
+ pic->input_surface = (VASurfaceID)(uintptr_t)frame->data[3];
pic->recon_surface = VA_INVALID_ID;
pic->output_buffer = VA_INVALID_ID;
@@ -1332,7 +1333,7 @@ static int vaapi_encode_send_frame(AVCodecContext *avctx, AVFrame *frame)
if (err < 0)
return err;
- pic = vaapi_encode_alloc(avctx);
+ pic = vaapi_encode_alloc(avctx, frame);
if (!pic)
return AVERROR(ENOMEM);
@@ -1345,7 +1346,6 @@ static int vaapi_encode_send_frame(AVCodecContext *avctx, AVFrame *frame)
if (ctx->input_order == 0 || frame->pict_type == AV_PICTURE_TYPE_I)
pic->force_idr = 1;
- pic->input_surface = (VASurfaceID)(uintptr_t)frame->data[3];
pic->pts = frame->pts;
pic->duration = frame->duration;
--
2.41.0.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-03 9:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 9:18 [FFmpeg-devel] [PATCH v13 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode tong1.wu-at-intel.com
2024-06-03 9:18 ` [FFmpeg-devel] [PATCH v13 02/15] avcodec/hw_base_encode: add FF_HW_ prefix for two enums tong1.wu-at-intel.com
2024-06-03 9:18 ` [FFmpeg-devel] [PATCH v13 03/15] avcodec/vaapi_encode: add async_depth to common options tong1.wu-at-intel.com
2024-06-03 9:18 ` [FFmpeg-devel] [PATCH v13 04/15] avcodec/vaapi_encode: add picture type name to base tong1.wu-at-intel.com
2024-06-03 9:18 ` tong1.wu-at-intel.com [this message]
2024-06-03 9:18 ` [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer tong1.wu-at-intel.com
2024-06-07 15:09 ` Lynne via ffmpeg-devel
2024-06-07 15:22 ` Wu, Tong1
2024-06-07 16:48 ` Lynne via ffmpeg-devel
2024-06-10 2:00 ` Lynne via ffmpeg-devel
2024-06-12 8:44 ` Wu, Tong1
2024-06-14 7:09 ` Lynne via ffmpeg-devel
2024-06-15 16:05 ` Tong Wu
2024-06-23 4:46 ` Wu Tong
2024-07-02 12:22 ` Lynne via ffmpeg-devel
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 07/15] avcodec/vaapi_encode: extract the init and close function " tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 08/15] avcodec/vaapi_encode: extract gop configuration and two options " tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 09/15] avcodec/vaapi_encode: extract set_output_property " tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 10/15] avcodec/vaapi_encode: extract a get_recon_format function " tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 11/15] avcodec/vaapi_encode: extract a free funtion " tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 12/15] avutil/hwcontext_d3d12va: add Flags for resource creation tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 13/15] avcodec: add D3D12VA hardware HEVC encoder tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 14/15] Changelog: add D3D12VA HEVC encoder changelog tong1.wu-at-intel.com
2024-06-03 9:19 ` [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx tong1.wu-at-intel.com
2024-06-06 6:10 ` Lynne via ffmpeg-devel
2024-06-06 6:46 ` Wu, Tong1
2024-06-06 12:30 ` Lynne via ffmpeg-devel
2024-06-06 13:12 ` Wu, Tong1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603091909.1161-5-tong1.wu@intel.com \
--to=tong1.wu-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=tong1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git