Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: tong1.wu-at-intel.com@ffmpeg.org
To: ffmpeg-devel@ffmpeg.org
Cc: Tong Wu <tong1.wu@intel.com>
Subject: [FFmpeg-devel] [PATCH v13 11/15] avcodec/vaapi_encode: extract a free funtion to base layer
Date: Mon,  3 Jun 2024 17:19:04 +0800
Message-ID: <20240603091909.1161-11-tong1.wu@intel.com> (raw)
In-Reply-To: <20240603091909.1161-1-tong1.wu@intel.com>

From: Tong Wu <tong1.wu@intel.com>

Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
 libavcodec/hw_base_encode.c | 11 +++++++++++
 libavcodec/hw_base_encode.h |  2 ++
 libavcodec/vaapi_encode.c   |  6 +-----
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
index 31046bd73e..92f69bb78c 100644
--- a/libavcodec/hw_base_encode.c
+++ b/libavcodec/hw_base_encode.c
@@ -745,6 +745,17 @@ fail:
     return err;
 }
 
+int ff_hw_base_encode_free(FFHWBaseEncodePicture *pic)
+{
+    av_frame_free(&pic->input_image);
+    av_frame_free(&pic->recon_image);
+
+    av_buffer_unref(&pic->opaque_ref);
+    av_freep(&pic->priv_data);
+
+    return 0;
+}
+
 int ff_hw_base_encode_init(AVCodecContext *avctx)
 {
     FFHWBaseEncodeContext *ctx = avctx->priv_data;
diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h
index f5414e2c28..15ef3d7ac6 100644
--- a/libavcodec/hw_base_encode.h
+++ b/libavcodec/hw_base_encode.h
@@ -224,6 +224,8 @@ int ff_hw_base_init_gop_structure(AVCodecContext *avctx, uint32_t ref_l0, uint32
 
 int ff_hw_base_get_recon_format(AVCodecContext *avctx, const void *hwconfig, enum AVPixelFormat *fmt);
 
+int ff_hw_base_encode_free(FFHWBaseEncodePicture *pic);
+
 int ff_hw_base_encode_init(AVCodecContext *avctx);
 
 int ff_hw_base_encode_close(AVCodecContext *avctx);
diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index d96f146b28..b35a23e852 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@ -878,17 +878,13 @@ static int vaapi_encode_free(AVCodecContext *avctx,
             av_freep(&pic->slices[i].codec_slice_params);
     }
 
-    av_frame_free(&base_pic->input_image);
-    av_frame_free(&base_pic->recon_image);
-
-    av_buffer_unref(&base_pic->opaque_ref);
+    ff_hw_base_encode_free(base_pic);
 
     av_freep(&pic->param_buffers);
     av_freep(&pic->slices);
     // Output buffer should already be destroyed.
     av_assert0(pic->output_buffer == VA_INVALID_ID);
 
-    av_freep(&base_pic->priv_data);
     av_freep(&pic->codec_picture_params);
     av_freep(&pic->roi);
 
-- 
2.41.0.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-06-03  9:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03  9:18 [FFmpeg-devel] [PATCH v13 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode tong1.wu-at-intel.com
2024-06-03  9:18 ` [FFmpeg-devel] [PATCH v13 02/15] avcodec/hw_base_encode: add FF_HW_ prefix for two enums tong1.wu-at-intel.com
2024-06-03  9:18 ` [FFmpeg-devel] [PATCH v13 03/15] avcodec/vaapi_encode: add async_depth to common options tong1.wu-at-intel.com
2024-06-03  9:18 ` [FFmpeg-devel] [PATCH v13 04/15] avcodec/vaapi_encode: add picture type name to base tong1.wu-at-intel.com
2024-06-03  9:18 ` [FFmpeg-devel] [PATCH v13 05/15] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc tong1.wu-at-intel.com
2024-06-03  9:18 ` [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer tong1.wu-at-intel.com
2024-06-07 15:09   ` Lynne via ffmpeg-devel
2024-06-07 15:22     ` Wu, Tong1
2024-06-07 16:48       ` Lynne via ffmpeg-devel
2024-06-10  2:00         ` Lynne via ffmpeg-devel
2024-06-12  8:44           ` Wu, Tong1
2024-06-14  7:09             ` Lynne via ffmpeg-devel
2024-06-15 16:05               ` Tong Wu
2024-06-23  4:46                 ` Wu Tong
2024-07-02 12:22                 ` Lynne via ffmpeg-devel
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 07/15] avcodec/vaapi_encode: extract the init and close function " tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 08/15] avcodec/vaapi_encode: extract gop configuration and two options " tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 09/15] avcodec/vaapi_encode: extract set_output_property " tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 10/15] avcodec/vaapi_encode: extract a get_recon_format function " tong1.wu-at-intel.com
2024-06-03  9:19 ` tong1.wu-at-intel.com [this message]
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 12/15] avutil/hwcontext_d3d12va: add Flags for resource creation tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 13/15] avcodec: add D3D12VA hardware HEVC encoder tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 14/15] Changelog: add D3D12VA HEVC encoder changelog tong1.wu-at-intel.com
2024-06-03  9:19 ` [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx tong1.wu-at-intel.com
2024-06-06  6:10   ` Lynne via ffmpeg-devel
2024-06-06  6:46     ` Wu, Tong1
2024-06-06 12:30       ` Lynne via ffmpeg-devel
2024-06-06 13:12         ` Wu, Tong1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603091909.1161-11-tong1.wu@intel.com \
    --to=tong1.wu-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=tong1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git