[FFmpeg-devel] [PATCH] avcodec/lpc: account for odd len values

[FFmpeg-devel] [PATCH] avcodec/lpc: account for odd len values

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/lpc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index dfd6114690..e793e54038 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
@@ -120,9 +120,8 @@ static void lpc_compute_autocorr_c(const double *data, ptrdiff_t len, int lag,
 
     if(j==lag){
         double sum = 1.0;
-        for(i=j-1; i<len; i+=2){
-            sum += data[i  ] * data[i-j  ]
-                 + data[i+1] * data[i-j+1];
+        for(i=j-1; i<len; i++){
+            sum += data[i] * data[i-j];
         }
         autoc[j] = sum;
     }
-- 
2.45.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/lpc: account for odd len values

[Rémi Denis-Courmont]

Le 31 mai 2024 15:39:35 GMT+03:00, James Almer <jamrial@gmail.com> a écrit :
>Signed-off-by: James Almer <jamrial@gmail.com>
>---
> libavcodec/lpc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
>index dfd6114690..e793e54038 100644
>--- a/libavcodec/lpc.c
>+++ b/libavcodec/lpc.c
>@@ -120,9 +120,8 @@ static void lpc_compute_autocorr_c(const double *data, ptrdiff_t len, int lag,
> 
>     if(j==lag){
>         double sum = 1.0;
>-        for(i=j-1; i<len; i+=2){
>-            sum += data[i  ] * data[i-j  ]
>-                 + data[i+1] * data[i-j+1];
>+        for(i=j-1; i<len; i++){
>+            sum += data[i] * data[i-j];
>         }
>         autoc[j] = sum;
>     }

LGTM 
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".