From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A4EBD483AA for ; Thu, 30 May 2024 23:49:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56D3A68D466; Fri, 31 May 2024 02:49:48 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E82E568CD5C for ; Fri, 31 May 2024 02:49:41 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 400DE1C0002 for ; Thu, 30 May 2024 23:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717112981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IuZ2bR9Ulkt1m7Sj/WoRTr65XbPlecmNDB6fWFJ5v9A=; b=FOxKxLr6V8CWTqLQNyHlEVAZS7izcp9Ef7BZAhZ68A44OmFOiwMdbZSZfhnb345vsfgEe5 xLG8uORYJRojr24avadqHshAdz0MU2fC+YiRTI7IsdjNoOqKObDtEMYAu5PnHto27w4Kth yJ3FOyUI3sPp2wfT+w9wAFt/8Fv7HxmSBI+DQb8Zg0JA9/+me0o+hgepG33Y9i/gR09Oku l9Buhm50gnuDz98oL8k+u7V9zQfJAs1YqU8OHywiI1pj2alJa+BgP+BbA+gpr+z5C4AI0m sSSgHG4xVSR+unuernOJTmzFwc+P2TkJ3P2Z31miCk2TdqDEHD6/WzqAToempA== Date: Fri, 31 May 2024 01:49:39 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240530234939.GH2821752@pb2> References: <20240530193836.2602182-1-wangcao@google.com> MIME-Version: 1.0 In-Reply-To: <20240530193836.2602182-1-wangcao@google.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] mov.c fix the duration for the last audio frame. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7281611721252152807==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7281611721252152807== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7TOCTzdPF11K2/Qe" Content-Disposition: inline --7TOCTzdPF11K2/Qe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 30, 2024 at 07:38:36PM +0000, Wang Cao via ffmpeg-devel wrote: > It is possible that the actual audio data only occupy part of the last au= dio frame. This can be signaled by duration in the "trun" atom. We should r= espect the metadata of file and set the duration correctly. > --- > libavformat/mov.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) please add a fate test thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --7TOCTzdPF11K2/Qe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlkQkAAKCRBhHseHBAsP qy1tAJ91Adjqpex/pFbllSe3MR1n2zXHwACglHIuhItN0evsFf2BUQ1xJrqmuxI= =QRXX -----END PGP SIGNATURE----- --7TOCTzdPF11K2/Qe-- --===============7281611721252152807== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7281611721252152807==--