From: Ramiro Polla <ramiro.polla@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 2/2] ffplay: set default scaling_quality to "best" instead of "linear"
Date: Thu, 30 May 2024 23:36:57 +0200
Message-ID: <20240530213657.1033191-2-ramiro.polla@gmail.com> (raw)
In-Reply-To: <20240530213657.1033191-1-ramiro.polla@gmail.com>
These values are aliases in SDL, but "best" is a more intuitive name.
---
doc/ffplay.texi | 2 +-
fftools/ffplay.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/ffplay.texi b/doc/ffplay.texi
index 60f883e159..e7ff62ae16 100644
--- a/doc/ffplay.texi
+++ b/doc/ffplay.texi
@@ -73,7 +73,7 @@ Force format.
@item -window_title @var{title}
Set window title (default is the input filename).
@item -scaling_quality @var{value}
-Set SDL_HINT_RENDER_SCALE_QUALITY value (default is "linear").
+Set SDL_HINT_RENDER_SCALE_QUALITY value (default is "best").
@item -left @var{title}
Set the x position for the left of the window (default is a centered window).
@item -top @var{title}
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 75d2bec777..6575ad14a7 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -3684,7 +3684,7 @@ static const OptionDef options[] = {
{ "framedrop", OPT_TYPE_BOOL, OPT_EXPERT, { &framedrop }, "drop frames when cpu is too slow", "" },
{ "infbuf", OPT_TYPE_BOOL, OPT_EXPERT, { &infinite_buffer }, "don't limit the input buffer size (useful with realtime streams)", "" },
{ "window_title", OPT_TYPE_STRING, 0, { &window_title }, "set window title", "window title" },
- { "scaling_quality", OPT_TYPE_STRING, OPT_EXPERT, { &scaling_quality }, "set SDL_HINT_RENDER_SCALE_QUALITY value (default=linear)", "value" },
+ { "scaling_quality", OPT_TYPE_STRING, OPT_EXPERT, { &scaling_quality }, "set SDL_HINT_RENDER_SCALE_QUALITY value (default=best)", "value" },
{ "left", OPT_TYPE_INT, OPT_EXPERT, { &screen_left }, "set the x position for the left of the window", "x pos" },
{ "top", OPT_TYPE_INT, OPT_EXPERT, { &screen_top }, "set the y position for the top of the window", "y pos" },
{ "vf", OPT_TYPE_FUNC, OPT_FUNC_ARG | OPT_EXPERT, { .func_arg = opt_add_vfilter }, "set video filters", "filter_graph" },
@@ -3834,7 +3834,7 @@ int main(int argc, char **argv)
}
window = SDL_CreateWindow(program_name, SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, default_width, default_height, flags);
if (!scaling_quality)
- scaling_quality = "linear";
+ scaling_quality = "best";
SDL_SetHint(SDL_HINT_RENDER_SCALE_QUALITY, scaling_quality);
if (!window) {
av_log(NULL, AV_LOG_FATAL, "Failed to create window: %s", SDL_GetError());
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-30 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 21:36 [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL Ramiro Polla
2024-05-30 21:36 ` Ramiro Polla [this message]
2024-06-04 13:00 ` Ramiro Polla
2024-06-10 19:04 ` Marton Balint
2024-06-11 11:08 ` Ramiro Polla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530213657.1033191-2-ramiro.polla@gmail.com \
--to=ramiro.polla@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git