From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DD4F94B0F4 for ; Tue, 28 May 2024 19:10:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03F7368D525; Tue, 28 May 2024 22:10:32 +0300 (EEST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C0EC68D353 for ; Tue, 28 May 2024 22:10:26 +0300 (EEST) Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6ab9e0a4135so991826d6.1 for ; Tue, 28 May 2024 12:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716923425; x=1717528225; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yb7VW7D3lwsnDRe0JqGB77oUoXTkTMy6Z7zrNN2ITbY=; b=Ng/5PO87YaUPPbxhtUj07Lq27zB5QF4FzkibNo1XV0cRX9NDNyE6hMnKsr8sg08aPM sIh81nDDpeLlXYnSXA8AlreIilyVv7elIsKldihtonTB7wbS+02tRCd/KTDMmnj1OKjt gQ8YrLkCP1ot5dJCldsFJceg32yOZHqGmqdbPUDp8psWT8POfniIcCfa7KAYAlxHHDxw 53lyRduu8NhbijqetQ3ViGET27WjArlYPhVQ+9XmkjNSNmDEfIhqOQSUhNUumNFEWF6U t1pcbpfwyflK+G0ln6bjKYGtg5sAy4EUWHLEcsuncwHB15J3Vu4LxV+2AS03kLSOIyV1 Q1Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923425; x=1717528225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yb7VW7D3lwsnDRe0JqGB77oUoXTkTMy6Z7zrNN2ITbY=; b=u7Eo1E3dryALPg5quYZdGKfWEK7//jYID2MHNDdCtUAn9teO8/bG/6STOMsUABmhzo W28ZqoMQ5lbH0vr32ofBPQ0ngR2xSlBLB/dlzOt4uNpSTvbt9km9nkyN6WPD1lPWdG2H 9bZUtZXe5FpLleLUo4EXZD3eeHF03QXu4xVeETBqNL7EFa4CJfP1ERrru1DOCzk1dUMs JD7Z9PwtanRquSyRxqFvsxy67lf+lXTGPW0OTUvKeQN1VibJdBPaIutcY2Cy+VtvjTxu 4C28D5WL95A43ei70LcIqXjIg5ed+NBVS3vHrcSM21/mlDOnUokdHoSP1LvB0Vqg9aPa QwJg== X-Gm-Message-State: AOJu0Yyx+R1hTmCEQ3CBmjSw26pDRrIbvLUjVVvbOPodFY8whUxmPrA5 RfVqE+uMRkuzH7qpI31jglQbJE4nhvc7l4xAJvZ2PLcKt4NJnCwGsgWTyIjZ X-Google-Smtp-Source: AGHT+IG47+0C6dNqWvpizjlqNUoDji/59SZfZcfGbeNDF/0EqAGIhr5asyneHUCwvaqD90ZUEPX22A== X-Received: by 2002:ad4:5762:0:b0:6ab:7ab4:f309 with SMTP id 6a1803df08f44-6ad9f935aadmr15666d6.1.1716923424607; Tue, 28 May 2024 12:10:24 -0700 (PDT) Received: from fedora.tailc94c2.ts.net (209-6-133-125.s1659.c3-0.bkl-cbr1.sbo-bkl.ma.cable.rcncustomer.com. [209.6.133.125]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac070c2e35sm46816776d6.9.2024.05.28.12.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 12:10:24 -0700 (PDT) From: Stone Chen To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 May 2024 15:09:02 -0400 Message-ID: <20240528190903.40811-5-chen.stonechen@gmail.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240528190903.40811-3-chen.stonechen@gmail.com> References: <20240528190903.40811-3-chen.stonechen@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v1 2/2][GSoC 2024] tests/checkasm/vvc_mc: for SAD, only test valid subblock sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stone Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: According to the VVC specification (section 8.5.1), the maximum width/height of a subblock passed for DMVR SAD is 16. This along with previous constraint requiring width * height >= 128 means that 8x16, 16x8, and 16x16 are the only allowed sizes. This changes check_vvc_sad() to only test and benchmark those sizes. --- tests/checkasm/vvc_mc.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c index 1e889e2cff..09cac82edb 100644 --- a/tests/checkasm/vvc_mc.c +++ b/tests/checkasm/vvc_mc.c @@ -337,11 +337,12 @@ static void check_vvc_sad(void) memset(src1, 0, MAX_CTU_SIZE * MAX_CTU_SIZE * 4 * sizeof(uint16_t)); randomize_pixels(src0, src1, MAX_CTU_SIZE * MAX_CTU_SIZE * 4); - for (int h = 8; h <= MAX_CTU_SIZE; h *= 2) { - for (int w = 8; w <= MAX_CTU_SIZE; w *= 2) { + for (int h = 8; h <= 16; h *= 2) { + for (int w = 8; w <= 16; w *= 2) { for(int offy = 0; offy <= 4; offy++) { for(int offx = 0; offx <= 4; offx++) { - if(check_func(c.inter.sad, "sad_%dx%d", w, h)) { + if(w * h >= 128) { + if(check_func(c.inter.sad, "sad_%dx%d", w, h)) { int result0; int result1; @@ -350,13 +351,14 @@ static void check_vvc_sad(void) if (result1 != result0) fail(); - if(w == h && offx == 0 && offy == 0) + if(offx == 0 && offy == 0) bench_new(src0 + PIXEL_STRIDE * 2 + 2, src1 + PIXEL_STRIDE * 2 + 2, offx, offy, w, h); + } } } } } - } + } report("sad"); } -- 2.45.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".