From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C69AD4B0FC for ; Tue, 28 May 2024 19:10:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B79068D500; Tue, 28 May 2024 22:09:58 +0300 (EEST) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C48BE68D2A4 for ; Tue, 28 May 2024 22:09:51 +0300 (EEST) Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6ab9d406101so6606116d6.3 for ; Tue, 28 May 2024 12:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716923390; x=1717528190; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UCaZer5ivYj9YIgpymSyPhvfZrZ7YPNaPxa8MdUd0fk=; b=eNwRxLNPBpymFaUr2ShMKS4QsR40mbeBz+UOXI3soWFkEOEwew7DOYtQ8xJQ3l9UHO 717qAHcGNofftCFa6MRoeJoNsw1bRpSDVDL8xOYs9yZ5upob042UkPs2R5OW3stMqAQD 5i2/lqILE6KK9SpcJrwJnuZAtDcZu50SoSiJiGNODBDHmh753MgELrfru7JbWuK3BFtk w0Nf/bi7pPrmGZDJb99ascvL54E3ScS41H7KjB+TuQiDJzJlYvIkIfgnhJTuFqHCEaC9 6H+f0M8dg7cSEkoh3A+gMITwiDQThb2pWHTevYCSozI+HcW62GRO0CETZSOySE4zX0x6 4sUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923390; x=1717528190; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UCaZer5ivYj9YIgpymSyPhvfZrZ7YPNaPxa8MdUd0fk=; b=bAVEAyohI1FjldfaZxteijUAYHQW+sT0I7dxNTmhwiSnjuwdrFrU8Kb5wOvXSRLf+T +GnK9yjtztgco7jIPnfzP7h57eC3aBieRAt3rD7/OEcaaVFywAtZ8/UphejAsXxFa7HK /LweyF3ttO0SiMgRySyfvlDmT03yMrrAHSUG9O0cjFxe23fTzZmcEQ93JkIzbJb7+dF0 VdHn4jRLQm3R1JtsUAF5zDJRhNPXKIhbOhS3sVt6WIloJGuGquAYq38zR34doV1AenBH 1iG/OMQIZ2IpgEr1hEcG/e2z3usFSYhtyXCkxL7zTQnZP6gKjIr65X1OPPB9dD6vf+9X tx8A== X-Gm-Message-State: AOJu0YzkKab4m9eDVvIPxsOZ7InyiTwSPsd/StBXVQpW98ESKAtDyzOb t6Rly57JZ542egenS0hLXnRjveIsZw6cjT2Oqp+x2CC519bP4F1p2alrtKfv X-Google-Smtp-Source: AGHT+IH2oUj74tvb6Vjmz9VJtStpFWLicmlzv+e6ZH5w8VYw7FEPwErUj5mngG1w9NUH5TOZhe9rrQ== X-Received: by 2002:a05:6214:3907:b0:69b:1d83:d884 with SMTP id 6a1803df08f44-6abcd134e34mr137971506d6.62.1716923389821; Tue, 28 May 2024 12:09:49 -0700 (PDT) Received: from fedora.tailc94c2.ts.net (209-6-133-125.s1659.c3-0.bkl-cbr1.sbo-bkl.ma.cable.rcncustomer.com. [209.6.133.125]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac070c2e35sm46816776d6.9.2024.05.28.12.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 12:09:49 -0700 (PDT) From: Stone Chen To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 May 2024 15:09:00 -0400 Message-ID: <20240528190903.40811-3-chen.stonechen@gmail.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v1 1/2][GSoC 2024] libavcode/x86/vvc: change label to vvc_sad_16 to reflect block sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stone Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: According to the VVC specification (section 8.5.1), the maximum width/height of a subblock passed for DMVR SAD is 16. This along with previous constraint requiring width * height >= 128 means that 8x16, 16x8, and 16x16 are the only allowed sizes. This re-labels vvc_sad_16_128 to vvc_sad_16 to reflect this and adds a comment about the block size constraints. There's no functionality change. --- libavcodec/x86/vvc/vvc_sad.asm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/vvc/vvc_sad.asm b/libavcodec/x86/vvc/vvc_sad.asm index b468d89ac2..982951a370 100644 --- a/libavcodec/x86/vvc/vvc_sad.asm +++ b/libavcodec/x86/vvc/vvc_sad.asm @@ -29,6 +29,7 @@ SECTION_RODATA pw_1: times 2 dw 1 ; DMVR SAD is only calculated on even rows to reduce complexity +; Additionally the only valid sizes are 8x16, 16x8, and 16x16 SECTION .text %macro MIN_MAX_SAD 3 @@ -77,7 +78,7 @@ cglobal vvc_sad, 6, 9, 5, src1, src2, dx, dy, block_w, block_h, off1, off2, row_ vpbroadcastd m4, [pw_1] cmp block_wd, 16 - jge vvc_sad_16_128 + je vvc_sad_16 vvc_sad_8: .loop_height: @@ -100,7 +101,7 @@ cglobal vvc_sad, 6, 9, 5, src1, src2, dx, dy, block_w, block_h, off1, off2, row_ movd eax, xm0 RET - vvc_sad_16_128: + vvc_sad_16: sar block_wd, 4 .loop_height: mov off1q, src1q -- 2.45.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".