From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C98948AAC for ; Mon, 27 May 2024 23:42:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9519968D4ED; Tue, 28 May 2024 02:42:28 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3153468D3C6 for ; Tue, 28 May 2024 02:42:22 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 814FF20002 for ; Mon, 27 May 2024 23:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716853341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PhQislmd8Os75j7CK2lW/GMACPyihr8H8qkGdwRHHyc=; b=XibogRKrBbvoR/CNo185ypGisXdZiuDXnq8hFxOia+RyHuc7oJXNZWCp/3/n5IQEYGSE5d quzHYqBj+hskxrytNqNIA+LrCjYEg64NMbHu3g3gE6Oty4Vf3OldMox3kyfMF+96VDfmao 4c2xjsQAR1t2nQ98UyomPy1I1yDkIjsHMtG7isKwKVk8W+qk1wrsTEAwtvRwf/km34Mjqe VdbSXqD+CttF81RcrGAJg+2kwTKt4julCawCH1SPch2+0MyKaifASDzjT7IA26hG9E/sz4 INdZbDs64wxzcn3co6rOrT1CLqp1MTgLgPQGda1EJN60LuIPfeyDMVly021EWQ== Date: Tue, 28 May 2024 01:42:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240527234218.GT2821752@pb2> References: <20240521024652.1006233-1-michael@niedermayer.cc> <20240521024652.1006233-7-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 7/7] tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0456030828243922091==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0456030828243922091== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XUmrTyVHrg2/ImRG" Content-Disposition: inline --XUmrTyVHrg2/ImRG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 21, 2024 at 10:07:56AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1524598 Improper use of negative value > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > tools/enc_recon_frame_test.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c > > index c099beb3f4b..d39d6303c2e 100644 > > --- a/tools/enc_recon_frame_test.c > > +++ b/tools/enc_recon_frame_test.c > > @@ -28,6 +28,7 @@ > > #include "decode_simple.h" > > =20 > > #include "libavutil/adler32.h" > > +#include "libavutil/avassert.h" > > #include "libavutil/common.h" > > #include "libavutil/error.h" > > #include "libavutil/frame.h" > > @@ -89,6 +90,8 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_= c, int64_t ts, > > int linesize =3D av_image_get_linesize(frame->format, frame->w= idth, p); > > uint32_t checksum =3D 0; > > =20 > > + av_assert1(linesize >=3D 0); > > + >=20 > This is a test tool; it should always be picky. will apply with av_assert0() thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --XUmrTyVHrg2/ImRG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlUaWgAKCRBhHseHBAsP q3S4AJ9wvBnpVaJwlsRoHIxopsj2iz8grgCeI7nQ36k5CH/RZTt0FLEykDu9j3E= =lkWc -----END PGP SIGNATURE----- --XUmrTyVHrg2/ImRG-- --===============0456030828243922091== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0456030828243922091==--