Re: [FFmpeg-devel] [PATCH 7/7] tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 7/7] tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds
Date: Tue, 28 May 2024 01:42:18 +0200
Message-ID: <20240527234218.GT2821752@pb2> (raw)
In-Reply-To: <GV1P250MB0737805EFB148BB2E4EC70748FEA2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

[-- Attachment #1.1: Type: text/plain, Size: 1532 bytes --]

On Tue, May 21, 2024 at 10:07:56AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Helps: CID1524598 Improper use of negative value
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  tools/enc_recon_frame_test.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c
> > index c099beb3f4b..d39d6303c2e 100644
> > --- a/tools/enc_recon_frame_test.c
> > +++ b/tools/enc_recon_frame_test.c
> > @@ -28,6 +28,7 @@
> >  #include "decode_simple.h"
> >  
> >  #include "libavutil/adler32.h"
> > +#include "libavutil/avassert.h"
> >  #include "libavutil/common.h"
> >  #include "libavutil/error.h"
> >  #include "libavutil/frame.h"
> > @@ -89,6 +90,8 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_c, int64_t ts,
> >          int linesize = av_image_get_linesize(frame->format, frame->width, p);
> >          uint32_t checksum = 0;
> >  
> > +        av_assert1(linesize >= 0);
> > +
> 
> This is a test tool; it should always be picky.

will apply with av_assert0()

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".