From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7DEED4B098 for ; Mon, 27 May 2024 19:21:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2EE568D4C3; Mon, 27 May 2024 22:21:03 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8700268D275 for ; Mon, 27 May 2024 22:20:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CDF97240002 for ; Mon, 27 May 2024 19:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716837657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YFJArjEm3R7dngKh+nshYwVJAgqhgk7WfkfCtv1Psts=; b=KN8ldBUxgECF/xFFwTfmcyS4rhACiRdc5Tyz+k5i9u3Tn7QbsRnsxszGg+vEJGQsaL52Xn 1IHadTs3CL84H/OURvmuZcY2mhXyQIlxFf8YZLj6kuFrDF1xtqhDNxOgSLElsupJ7mf7Qy VZcyDlquCbTbpyPLDQadiHFt4hyiUYxeGKxyEAwIFCsgnqW5L3nrPesenhbxAMKKc20ewV OrXzyKs2BdBbhGxDugP+SAr0A12G+pVGKicYhuDSUt/630CiGV1tIPWy3ljhPJKeAzrfVF 5X0KxFLCSy/58zyA0dFJjGeuJH3mKs2ePav6e7j8/o8H7n0UxwXgbKVrF4hVFQ== Date: Mon, 27 May 2024 21:20:55 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240527192055.GO2821752@pb2> References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> <20240527181105.GN2821752@pb2> <703eafba-1d9a-458b-a4ee-f2092a73bd83@gmail.com> MIME-Version: 1.0 In-Reply-To: <703eafba-1d9a-458b-a4ee-f2092a73bd83@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6166195757299170845==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6166195757299170845== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FTsVDVnBYKo0tCDH" Content-Disposition: inline --FTsVDVnBYKo0tCDH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: > On 5/27/2024 3:11 PM, Michael Niedermayer wrote: > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-04-27 02:36:23) > > > > This allows detecting issues in side data related code, same as what > > > > framecrc does for before already for packet data itself. > > > >=20 > > > > Signed-off-by: Michael Niedermayer > > > > --- > > >=20 > > > I am against this patch. Checksumming side data is a fundamentally wr= ong > > > thing to do. > >=20 > > It, or something equivalent is neccessary for regression testing. > > (and it was you who asked also for the tests i run to be part of > > fate. But here you object to it) > >=20 > > You know, not checking side data is not checking it so differences woul= d then not be > > detected allowing for unintended changes to be introduced (aka bugs) >=20 > You have seen how much code is needed to get hashing to work for all targ= ets > with some types, framecrcenc.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++--- 1 file changed, 73 insertions(+), 3 deletions(-) 70 more lines of code, in my patch If we need another 70 to handle some corner cases, no idea if we do, thats still negligible > so it does feel like it's not the right thing to do. I dont think i can follow that logic > ffprobe (and f_sidedata) are what should be used for actual integrity > checks. ffprobe cannot test ffmpeg, ffmpeg is a seperate excutable If you suggest that side data should not be tested in FFmpeg while packet.d= ata should be tested. That position seems inconsistant to me If you suggest that neither side data nor packet.data should be tested in F= Fmpeg iam confident that there would be a majority disagreeing. f_sidedata is not at the output of ffmpeg so even if it could test it, it does not test the ffmpeg output. We also dont replace running md5sum and framecrc on ffmpeg output by a bits= tream filter. Again, there is need to test what comes out of FFmpeg, thats at the muxer l= evel thats what framecrcenc does. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream we wish for rather than the science we have, -- Dr. Kenneth Brown --FTsVDVnBYKo0tCDH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlTdEQAKCRBhHseHBAsP q9F6AJ0TMTk9kiV/fZSiA1s+opr1rCptxwCfSXYm7+3j6F//1pAugAcHmqan7HQ= =hkMN -----END PGP SIGNATURE----- --FTsVDVnBYKo0tCDH-- --===============6166195757299170845== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6166195757299170845==--