From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D53844B094 for ; Mon, 27 May 2024 18:11:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A16C68D4BE; Mon, 27 May 2024 21:11:14 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3465E68A604 for ; Mon, 27 May 2024 21:11:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 50F3D240002 for ; Mon, 27 May 2024 18:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716833466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GfuBozt52Ani86Ckrm2IfpTpqFKUK5Xl+PCzk2ge51M=; b=GxlQYmkXy2ztODsVCpX7CxYHN8ezwISqEJ7fexqzzFfnqeY0i9KmkSfi0gWeJ/XboFtZAq ejDoPYFhGZprIZbXBYBAGvbm0m12/142wmylxbL6edcWzJ5g+u3RTuzzO/FoqsAw/fdnD2 V1IcFzeCl7TuvX6runD2NRjMG5kGuxEbZtM4nErqYE4k+Mlr/g8FXn8uvDpqS6RNKT/UIy jRkZfjKxIk5AIaXBOA0mdbBI4W24YyPBkPZsIYkxz6ij1V5ibyzW/ZuSw2ZeFXy0nHfPGs lVC99cSjdywxc42SxrKZFiFeKxXCE8UJuz2XvfaZmVjtvPpcYyqNES0YSUdygA== Date: Mon, 27 May 2024 20:11:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240527181105.GN2821752@pb2> References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <171679774316.28895.4366606367617414113@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5972302109330418124==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5972302109330418124== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6kWzDLe2BYLyVXGp" Content-Disposition: inline --6kWzDLe2BYLyVXGp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-04-27 02:36:23) > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > >=20 > > Signed-off-by: Michael Niedermayer > > --- >=20 > I am against this patch. Checksumming side data is a fundamentally wrong > thing to do. It, or something equivalent is neccessary for regression testing. (and it was you who asked also for the tests i run to be part of fate. But here you object to it) You know, not checking side data is not checking it so differences would th= en not be detected allowing for unintended changes to be introduced (aka bugs) If you block this solution without providing another solution then i will bring this to the technical committee, to seek its guidance on the way forward. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --6kWzDLe2BYLyVXGp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlTMrwAKCRBhHseHBAsP q4WZAJ9xJ1iHld/qXV/CoBE/4v8Nov1g1gCfYQwsp68+tE2+toK3lwSWxJPwn6o= =1kxy -----END PGP SIGNATURE----- --6kWzDLe2BYLyVXGp-- --===============5972302109330418124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5972302109330418124==--