Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1152 bytes --]

On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-04-27 02:36:23)
> > This allows detecting issues in side data related code, same as what
> > framecrc does for before already for packet data itself.
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> 
> I am against this patch. Checksumming side data is a fundamentally wrong
> thing to do.

It, or something equivalent is neccessary for regression testing.
(and it was you who asked also for the tests i run to be part of
 fate. But here you object to it)

You know, not checking side data is not checking it so differences would then not be
detected allowing for unintended changes to be introduced (aka bugs)

If you block this solution without providing another solution
then i will bring this to the technical committee, to seek its guidance
on the way forward.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".