From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A57C34B053 for ; Sun, 26 May 2024 23:54:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D6A768D5EB; Mon, 27 May 2024 02:52:58 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8813768D598 for ; Mon, 27 May 2024 02:52:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BE8B540002 for ; Sun, 26 May 2024 23:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716767559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkdJhyXhu7loYsAHA4744wMfU4NbjuVsAAPtcaP1d4s=; b=XaIR7jIUIP3ySQo0bJNmgU7+9MCV6z3xm3X4rW/Zw+UHF7cyOWsZrUP7WZY3x3tiX4RRLs JbDoKUPcblrdUZDbNKLJXEfjvYceA9FuKbv5gdQjDvcA/pFjKAdjqPURf5MlQA7ksON9jr r3AOvmyJ+MPoYPxl8iCLKyfSIdsMLo96put5Ve13uOOLN7724TyWDQIzKQfWC7lG8NwAYT w1hNWaOGWF1sSEeYwgh38LKNk/uNbj65I9rSkY4cfGJ7h0EXwqQHr9SjNOeWqN74FMIaJi OsBilfZEifOXlZg/q7ON51q9Ktrx1uptP+ugKLc9hW71GeMd0Ixz31O0wctbug== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 27 May 2024 01:52:22 +0200 Message-ID: <20240526235230.2876318-10-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526235230.2876318-1-michael@niedermayer.cc> References: <20240526235230.2876318-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 10/17] avdevice/dshow: Remove NULL check on pin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The pointer is used before the check Fixes: CID1591884 Dereference before null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 0330d1d0b6c..8942c0c499a 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -432,8 +432,8 @@ dshow_get_device_media_types(AVFormatContext *avctx, enum dshowDeviceType devtyp IEnumMediaTypes_Release(types); if (p) IKsPropertySet_Release(p); - if (pin) - IPin_Release(pin); + + IPin_Release(pin); } IEnumPins_Release(pins); -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".