From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DFD014AFEC for ; Sat, 25 May 2024 22:12:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CD32F68D4DB; Sun, 26 May 2024 01:12:31 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C3BE68CE05 for ; Sun, 26 May 2024 01:12:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A3C5A60002 for ; Sat, 25 May 2024 22:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716675144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yQO6PDAKf8/MGVLfKo/1NGqLZyxEgTjvB8LtL1BNehc=; b=PFL3sEzEwbI0aZ/6G9ZiBavFA0xzfQI7xU/n8lJZDgiKJbzDS/I7UACzDbXl9fL4x38vEl pXyu3f62YdrMlJRRdr17RZyDmoCHabjPZkCS5en8CojKZZR7vFTBuPpqJK3ka/rm2Uo0rd cUBPxWb2iYlf5Z84LS9c1KGnGlk83qbMoYEL5warOIKXW/ZKoSHUl/HlvfaZWG/V6nUpfM 4fKxjEi4/+HWGZsNWI6TqSUZvvYI76uKoC3IAiDH44rOTW8W42CCyK+gvHrTtXBdyMriqI 0uxqySGTRzjjuv+ED3dAFc90dc4mcSmXBZFzs8jWk2rX55l/i3rKg5kFGxse9Q== Date: Sun, 26 May 2024 00:12:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240525221223.GF2821752@pb2> References: <20240525205731.2578146-1-dev@lynne.ee> MIME-Version: 1.0 In-Reply-To: <20240525205731.2578146-1-dev@lynne.ee> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7363402517930507148==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7363402517930507148== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k9EanI4qvbxMqdC7" Content-Disposition: inline --k9EanI4qvbxMqdC7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2024 at 10:57:21PM +0200, Lynne via ffmpeg-devel wrote: > The inline asm function had issues running under checkasm. > So I came to finish what I started, and wrote the last part > of LPC computation in assembly. >=20 > autocorr_10_c: 135525.8 > autocorr_10_sse2: 50729.8 > autocorr_10_fma3: 19007.8 > autocorr_30_c: 390100.8 > autocorr_30_sse2: 142478.8 > autocorr_30_fma3: 50559.8 > autocorr_32_c: 407058.3 > autocorr_32_sse2: 151633.3 > autocorr_32_fma3: 50517.3 > --- > libavcodec/x86/lpc.asm | 91 +++++++++++++++++++++++++++++++++++++++ > libavcodec/x86/lpc_init.c | 87 ++++--------------------------------- > 2 files changed, 100 insertions(+), 78 deletions(-) breaks build on x86-32 src/libavcodec/x86/lpc.asm:352: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:275: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1636: ... from macro `movaps' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavcodec/x86/lpc.asm:352: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:300: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1535: ... from macro `addpd' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavcodec/x86/lpc.asm:352: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:307: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1659: ... from macro `movups' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavcodec/x86/lpc.asm:354: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:275: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1636: ... from macro `movaps' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here src/libavcodec/x86/lpc.asm:354: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:297: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1937: ... from macro `fmaddpd' defined here src/libavcodec/x86/lpc.asm:354: error: symbol `m8' undefined src/libavcodec/x86/lpc.asm:307: ... from macro `COMPUTE_AUTOCORR_FN' define= d here src//libavutil/x86/x86inc.asm:1659: ... from macro `movups' defined here src//libavutil/x86/x86inc.asm:1501: ... from macro `RUN_AVX_INSTR' defined = here make: *** [src/ffbuild/common.mak:103: libavcodec/x86/lpc.o] Error 1 make: *** Waiting for unfinished jobs.... thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --k9EanI4qvbxMqdC7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlJiQAAKCRBhHseHBAsP q+t4AJ4iR8AVw1uFP1oQH+UftKJFxm7n8gCfcZCCkd120C5yk6MDmt2aXifb9h8= =10bt -----END PGP SIGNATURE----- --k9EanI4qvbxMqdC7-- --===============7363402517930507148== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7363402517930507148==--