From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 44D0B4AFA2 for ; Sat, 25 May 2024 12:20:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D94C68D575; Sat, 25 May 2024 15:19:59 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD3B568D27C for ; Sat, 25 May 2024 15:19:52 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CC87EC0003 for ; Sat, 25 May 2024 12:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716639592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iTWk9Zvo81vmiJnEw5MmF0zrw22llDIBu9Mcqj/iNs8=; b=JVRhaTA1VozRMakuRmUw7Z5HTchSRg78MqpG3B3gsdmwa2M0cQVxlL/c19bQxIdBfqPC8+ xGfbnZUD6QtCSBafvgmTOgXfHjrkGNKob1kgPgzhd75CuPYQbQTx0hAL8RGQAOLIm/9ofz b4KV6QTzY6UUKpMnkJBLX6V4BSGTMO3qPwaU/AXj+DkarSiAldJLD20lbjJeYS7fQpa/7T qE4YwVgSaJLS6q8P6+6rX4oHjpjfUIFVB5JHVqaKt/HQt8nR6lv6EjxzD8PeVB4r5oodQ5 nHMjy9rSujYzH8tBVOWmDW7e72YpQkNLDpDijrSrs3V0Q23lTbEJpDJpLFXL5w== Date: Sat, 25 May 2024 14:19:51 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240525121951.GE2821752@pb2> References: <20240525111814.2587729-1-michael@niedermayer.cc> <1932279.taCxCBeP46@basile.remlab.net> MIME-Version: 1.0 In-Reply-To: <1932279.taCxCBeP46@basile.remlab.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2189263798859150234==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2189263798859150234== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oPYnW2SrAqZUvu4n" Content-Disposition: inline --oPYnW2SrAqZUvu4n Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2024 at 02:38:07PM +0300, R=E9mi Denis-Courmont wrote: > Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a = =E9crit : > > Fixes: CID1559855 Unchecked return value from library >=20 > This is again very misleading. Logging an error (that most people won't e= ven=20 > see) is not fixing a bug. Either this is not a bug, and this patch can't = be=20 > fixing a non-bug, or this is a bug, and this patch is hiding it behind a = fake=20 > fix. As written in the commit message, the patch would fix CID1559855. It doesnt claim anything else [...] >=20 > So IMO, 5c3d2177e7be7dde69a83b1b394f57976c164c84 should be reverted inste= ad. if thats preferred, i have nothing against doing that instead thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --oPYnW2SrAqZUvu4n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlHXYwAKCRBhHseHBAsP q01bAKCG5/aaNdXVWfEeCxp9qhzBma38WwCdE09jBowh7e7xlmRoFTJef/XoA6E= =wiLn -----END PGP SIGNATURE----- --oPYnW2SrAqZUvu4n-- --===============2189263798859150234== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2189263798859150234==--