From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure
Date: Sat, 25 May 2024 14:19:51 +0200
Message-ID: <20240525121951.GE2821752@pb2> (raw)
In-Reply-To: <1932279.taCxCBeP46@basile.remlab.net>
[-- Attachment #1.1: Type: text/plain, Size: 899 bytes --]
On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote:
> Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit :
> > Fixes: CID1559855 Unchecked return value from library
>
> This is again very misleading. Logging an error (that most people won't even
> see) is not fixing a bug. Either this is not a bug, and this patch can't be
> fixing a non-bug, or this is a bug, and this patch is hiding it behind a fake
> fix.
As written in the commit message, the patch would fix CID1559855.
It doesnt claim anything else
[...]
>
> So IMO, 5c3d2177e7be7dde69a83b1b394f57976c164c84 should be reverted instead.
if thats preferred, i have nothing against doing that instead
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Never trust a computer, one day, it may think you are the virus. -- Compn
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-25 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 11:18 Michael Niedermayer
2024-05-25 11:18 ` [FFmpeg-devel] [PATCH 2/3] avformat/fwse: Remove always false expression Michael Niedermayer
2024-06-02 19:04 ` Michael Niedermayer
2024-05-25 11:18 ` [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Remove dead ret stores Michael Niedermayer
2024-05-25 12:41 ` Steven Liu
2024-05-25 11:38 ` [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure Rémi Denis-Courmont
2024-05-25 12:19 ` Michael Niedermayer [this message]
2024-05-25 12:36 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240525121951.GE2821752@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git