From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0C4024ACFB for ; Sat, 25 May 2024 11:18:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B0FE68CF47; Sat, 25 May 2024 14:18:22 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFA3668CADA for ; Sat, 25 May 2024 14:18:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 047BD40004 for ; Sat, 25 May 2024 11:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716635895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tbQfOuiyOdmpv+NNfzik5FF8pkSpuZdoOB92b1v7DHc=; b=d9aT9QXYsHNl+m+4kSXQq1b5eaLHDQUwyQOiTg9Iea2IpytA71MTpZzASQvPIWCk4SP3v/ eQulcg17uJFkHu4KcNjd/lZmmHyv1EZzbTKABqmnbJXCuWZLy1CNRkc21+X8N9Z+O1paJQ E6V8nn0pinfhU3Vyp+Je2b70Xx1o0LcXmzfGGTIPgNWzK+VRNXgUZ7HaAJqt5Q8xQwnyAG lo4dQ/HTnMdFeDTB+sUlnamIYvJno7y88Iy0KMVizWoU++wxtRY3arX7PvW0nVMhn/n3XR +tNw+YiT3cKG2cr0DXL3/kvnTTSnxfoJm1PgwGW9L7nFD3NzDttzhgY9cFrYRQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 25 May 2024 13:18:12 +0200 Message-ID: <20240525111814.2587729-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: CID1559855 Unchecked return value from library Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/file.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 0ed4cff266c..e2ef85aa705 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -222,8 +222,10 @@ static int file_close(URLContext *h) FileContext *c = h->priv_data; int ret; - if (c->initial_pos >= 0 && !h->is_streamed) - lseek(c->fd, c->initial_pos, SEEK_SET); + if (c->initial_pos >= 0 && !h->is_streamed) { + if (lseek(c->fd, c->initial_pos, SEEK_SET) < 0) + av_log(h, AV_LOG_DEBUG, "Failed to restore position (%s)\n", av_err2str(AVERROR(errno))); + } ret = close(c->fd); return (ret == -1) ? AVERROR(errno) : 0; -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".