From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 636244AF57 for ; Fri, 24 May 2024 19:41:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44A7568D57B; Fri, 24 May 2024 22:41:12 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3DC6C68CFDA for ; Fri, 24 May 2024 22:41:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3ACAC1C0005 for ; Fri, 24 May 2024 19:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716579665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ga8A+9rudbkPbSDcmwAW84ycpRJjJ7/AI8XDYt0fh1A=; b=ITGroPWxvfTmcwQM+8R6lzz1nrED2075uR/O/sdC63m/FCWDJjKX9J2GEjG95uFRG/dGLO Hq+OQ6i4ozpErN+LZbVHf2utAH++G93+x40sbftrPijwwPPmJfvy+mMpNVOr4sAxeqws7j ytPE+cp41B+1GXvhK6wMFk43XigS0H2V+PhmoCrb8/zbM00bkr6g2Pg/eDByI2/I+O/enq 3/tw8R5ckhwp1bg+jw9sN/upajXRmHHqazSQp8ymhoRYM8tgjWv61GsnkF/wSNR2pDDMLn oaWt7CkizZ4OFUztuwWYEV83E4sQpaqMPCHWJIK5ePxfPG8DnI+HgIMAzLUBDQ== Date: Fri, 24 May 2024 21:41:04 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240524194104.GZ2821752@pb2> References: <20240523090339.4228-1-anton@khirnov.net> <20240523090339.4228-2-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240523090339.4228-2-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6811877542438053429==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6811877542438053429== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jIdBwf7/i7YThJrI" Content-Disposition: inline --jIdBwf7/i7YThJrI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024 at 11:03:37AM +0200, Anton Khirnov wrote: > Share the code between encoding and decoding. Instead of checking every > stream's options dictionary (which is also used for other purposes), > track all used options in a dedicated dictionary. > --- > fftools/cmdutils.c | 17 ++++++++---- > fftools/cmdutils.h | 4 ++- > fftools/ffmpeg.c | 49 ++++++++++++++++++++++++++++++++++ > fftools/ffmpeg.h | 3 ++- > fftools/ffmpeg_demux.c | 50 ++++++++--------------------------- > fftools/ffmpeg_mux.c | 1 + > fftools/ffmpeg_mux.h | 3 +++ > fftools/ffmpeg_mux_init.c | 55 +++++---------------------------------- > fftools/ffmpeg_opt.c | 18 ------------- > fftools/ffplay.c | 2 +- > fftools/ffprobe.c | 2 +- > 11 files changed, 89 insertions(+), 115 deletions(-) breaks https://samples.ffmpeg.org/image-samples/exr/sub.0030.exr =2E/ffmpeg -layer RenderLayer.Color -gamma 2.2 -i sub.0030.exr -bitexact = /tmp/test-color2.2.jpg Input #0, exr_pipe, from 'sub.0030.exr': Duration: N/A, bitrate: N/A Stream #0:0: Video: exr, gbrapf32le, 960x540 [SAR 1:1 DAR 16:9], 25 fps, = 25 tbr, 25 tbn [in#0/exr_pipe @ 0x55c06b88b7c0] Codec AVOption gamma (set gamma) is not a = decoding option. Error opening input file sub.0030.exr. Error opening input files: Invalid argument thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --jIdBwf7/i7YThJrI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZlDtRwAKCRBhHseHBAsP q724AJ9voo70SlpAtV1EUpMmkf9dI2+NhACgi8slinzYrdY5kjZ4ZcS6b6o5heY= =C4Et -----END PGP SIGNATURE----- --jIdBwf7/i7YThJrI-- --===============6811877542438053429== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6811877542438053429==--