From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used
Date: Fri, 24 May 2024 21:41:04 +0200
Message-ID: <20240524194104.GZ2821752@pb2> (raw)
In-Reply-To: <20240523090339.4228-2-anton@khirnov.net>
[-- Attachment #1.1: Type: text/plain, Size: 1592 bytes --]
On Thu, May 23, 2024 at 11:03:37AM +0200, Anton Khirnov wrote:
> Share the code between encoding and decoding. Instead of checking every
> stream's options dictionary (which is also used for other purposes),
> track all used options in a dedicated dictionary.
> ---
> fftools/cmdutils.c | 17 ++++++++----
> fftools/cmdutils.h | 4 ++-
> fftools/ffmpeg.c | 49 ++++++++++++++++++++++++++++++++++
> fftools/ffmpeg.h | 3 ++-
> fftools/ffmpeg_demux.c | 50 ++++++++---------------------------
> fftools/ffmpeg_mux.c | 1 +
> fftools/ffmpeg_mux.h | 3 +++
> fftools/ffmpeg_mux_init.c | 55 +++++----------------------------------
> fftools/ffmpeg_opt.c | 18 -------------
> fftools/ffplay.c | 2 +-
> fftools/ffprobe.c | 2 +-
> 11 files changed, 89 insertions(+), 115 deletions(-)
breaks https://samples.ffmpeg.org/image-samples/exr/sub.0030.exr
./ffmpeg -layer RenderLayer.Color -gamma 2.2 -i sub.0030.exr -bitexact /tmp/test-color2.2.jpg
Input #0, exr_pipe, from 'sub.0030.exr':
Duration: N/A, bitrate: N/A
Stream #0:0: Video: exr, gbrapf32le, 960x540 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 25 tbn
[in#0/exr_pipe @ 0x55c06b88b7c0] Codec AVOption gamma (set gamma) is not a decoding option.
Error opening input file sub.0030.exr.
Error opening input files: Invalid argument
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-24 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 9:03 [FFmpeg-devel] [PATCH 1/4] lavc/qsvenc: rename the skip_frame private option to qsv_skip_frame Anton Khirnov
2024-05-23 9:03 ` [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used Anton Khirnov
2024-05-23 18:03 ` Marton Balint
2024-05-24 19:41 ` Michael Niedermayer [this message]
2024-05-23 9:03 ` [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_mux_init: apply encoder options manually Anton Khirnov
2024-05-23 9:03 ` [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg_mux_init: make encoder_opts local to ost_add() Anton Khirnov
2024-05-24 2:36 ` [FFmpeg-devel] [PATCH 1/4] lavc/qsvenc: rename the skip_frame private option to qsv_skip_frame Xiang, Haihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524194104.GZ2821752@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git