From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1EFF48D06 for ; Fri, 24 May 2024 01:11:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D11C768D547; Fri, 24 May 2024 04:11:53 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 75EB568D4F6 for ; Fri, 24 May 2024 04:11:47 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C3A4E1C0003 for ; Fri, 24 May 2024 01:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716513106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2Y8+0r4RyNISs/bpDB3Jpozp1k0QRl1WTdoqWfdCVY=; b=mPCaa2vGfY4XXFPeeDGUODCCBgVbBHmTQzsKjQK7x6ew4X8JHA81rf3DT8Ptx2954EdCmZ /eyofVu3YknWyFc90pAC0t8KIEj4KxRQwhOIIarNVBBzfvdZPof8awa4vvFnd+0ToBAl22 Vq74P+44KFDjNuDDXRLQmx0VcC65jkzw2CT16p0Si6uK8QEjQWlvf9n9oDa6XSYNhbKa7u pJ5BCpdn+6hRK5z6vrHTC1yyDD1wj87fjteY3I/kCHY+xbFF/Ng5EOJJBek2iaPzdlTVqU wyBeppgq40HvOnIXQh27zMzwXgd5daDVX1pggXnnnTK2qumY4owkaUt7noyHtQ== Date: Fri, 24 May 2024 03:11:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240524011146.GW2821752@pb2> References: <20240523011758.2434580-1-michael@niedermayer.cc> <20240523011758.2434580-7-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6840265999829602496==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6840265999829602496== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U7NLafZe7Bh9OCap" Content-Disposition: inline --U7NLafZe7Bh9OCap Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024 at 10:22:56AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1518967 Unchecked return value > > Helps: CID1518968 Unchecked return value > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/tests/bitstream_template.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/tests/bitstream_template.c b/libavcodec/tests/b= itstream_template.c > > index ef59845154d..d8cf980bee1 100644 > > --- a/libavcodec/tests/bitstream_template.c > > +++ b/libavcodec/tests/bitstream_template.c > > @@ -74,7 +74,7 @@ int main(int argc, char **argv) > > for (unsigned i =3D 0; i < SIZE; i++) > > buf[i] =3D av_lfg_get(&lfg); > > =20 > > - bits_init8 (&bc, buf, SIZE); > > + (void)bits_init8 (&bc, buf, SIZE); > > init_put_bits(&pb, dst, SIZE); > > =20 > > /* use a random sequence of bitreading operations to transfer data >=20 > Test tools should actually test. will replace with a assert0() then thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --U7NLafZe7Bh9OCap Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZk/pTgAKCRBhHseHBAsP q+HwAJ4+xyz2+Fgjz/hOXOpsuFE91xi8RQCfV1BZYtVtyOreoTxXYLKo3q3e6xk= =DTTV -----END PGP SIGNATURE----- --U7NLafZe7Bh9OCap-- --===============6840265999829602496== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6840265999829602496==--