Re: [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

On Thu, May 23, 2024 at 10:22:56AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Helps: CID1518967 Unchecked return value
> > Helps: CID1518968 Unchecked return value
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/tests/bitstream_template.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/tests/bitstream_template.c b/libavcodec/tests/bitstream_template.c
> > index ef59845154d..d8cf980bee1 100644
> > --- a/libavcodec/tests/bitstream_template.c
> > +++ b/libavcodec/tests/bitstream_template.c
> > @@ -74,7 +74,7 @@ int main(int argc, char **argv)
> >      for (unsigned i = 0; i < SIZE; i++)
> >          buf[i] = av_lfg_get(&lfg);
> >  
> > -    bits_init8   (&bc, buf, SIZE);
> > +    (void)bits_init8   (&bc, buf, SIZE);
> >      init_put_bits(&pb, dst, SIZE);
> >  
> >      /* use a random sequence of bitreading operations to transfer data
> 
> Test tools should actually test.

will replace with a assert0() then

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".