From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C41674AE5C for ; Wed, 22 May 2024 02:00:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B64268D359; Wed, 22 May 2024 05:00:07 +0300 (EEST) Received: from mail.overt.org (unknown [72.14.183.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6403A6801F2 for ; Wed, 22 May 2024 05:00:00 +0300 (EEST) Received: from authenticated-user (mail.overt.org [72.14.183.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.overt.org (Postfix) with ESMTPSA id 074D760208 for ; Tue, 21 May 2024 20:59:55 -0500 (CDT) Date: Tue, 21 May 2024 18:59:54 -0700 To: ffmpeg-devel@ffmpeg.org Message-ID: <20240521185954.7816d192@fido7> In-Reply-To: <20240514190759.62de075f@fido7> References: <20240514200643.721-1-llyyr.public@gmail.com> <20240514190759.62de075f@fido7> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Philip Langdale via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Philip Langdale Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 14 May 2024 19:07:59 -0700 Philip Langdale via ffmpeg-devel wrote: > On Wed, 15 May 2024 01:36:43 +0530 > llyyr.public@gmail.com wrote: > > > From: llyyr > > > > ab77b878f1 attempted to fix the issue of broken packets being sent > > to the decoder by implementing logic that kept attempting to > > PTS-step backwards until it reached a valid point, however applying > > this heuristic meant that in files that had no valid points (such > > as HEVC videos shot on iPhones), we'd seek back to sample 0 on > > every seek attempt. This meant that files that were previously > > seekable, albeit with some skipped frames, were not seekable at all > > now. > > > > Relax this heuristic a bit by giving up on seeking to a valid point > > if we've tried a different sample and we still don't have a valid > > point to seek to. This may some frames to be skipped on seeking but > > it's better than not being able to seek at all in such files. > > > > Fixes: ab77b878f1 ("avformat/mov: fix seeking with HEVC open GOP > > files") Fixes: #10585 > > LGTM. > > I know it's been a _long time_ since you first sent this; I'll push > next week if there aren't any other comments. > Pushed. Thanks! --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".