Re: [FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

[Philip Langdale via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

On Tue, 14 May 2024 19:07:59 -0700
Philip Langdale via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:

> On Wed, 15 May 2024 01:36:43 +0530
> llyyr.public@gmail.com wrote:
> 
> > From: llyyr <llyyr.public@gmail.com>
> > 
> > ab77b878f1 attempted to fix the issue of broken packets being sent
> > to the decoder by implementing logic that kept attempting to
> > PTS-step backwards until it reached a valid point, however applying
> > this heuristic meant that in files that had no valid points (such
> > as HEVC videos shot on iPhones), we'd seek back to sample 0 on
> > every seek attempt. This meant that files that were previously
> > seekable, albeit with some skipped frames, were not seekable at all
> > now.
> > 
> > Relax this heuristic a bit by giving up on seeking to a valid point
> > if we've tried a different sample and we still don't have a valid
> > point to seek to. This may some frames to be skipped on seeking but
> > it's better than not being able to seek at all in such files.
> > 
> > Fixes: ab77b878f1 ("avformat/mov: fix seeking with HEVC open GOP
> > files") Fixes: #10585
> 
> LGTM.
> 
> I know it's been a _long time_ since you first sent this; I'll push
> next week if there aren't any other comments.
> 

Pushed. Thanks!

--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".