[FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

[FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

[Lynne via ffmpeg-devel]

Helps make sense of the possible noise in the results.
---
 tests/checkasm/checkasm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 669f2be9c1..b1c175b95d 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -892,6 +892,9 @@ int main(int argc, char *argv[])
     fprintf(stderr, "checkasm: using random seed %u\n", seed);
     av_lfg_init(&checkasm_lfg, seed);
 
+    if (state.bench_pattern)
+        fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs));
+
     check_cpu_flag(NULL, 0);
     for (i = 0; cpus[i].flag; i++)
         check_cpu_flag(cpus[i].name, cpus[i].flag);
-- 
2.43.0.381.gb435a96ce8
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

[J. Dekker]

Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> writes:

> Helps make sense of the possible noise in the results.
> ---
>  tests/checkasm/checkasm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
> index 669f2be9c1..b1c175b95d 100644
> --- a/tests/checkasm/checkasm.c
> +++ b/tests/checkasm/checkasm.c
> @@ -892,6 +892,9 @@ int main(int argc, char *argv[])
>      fprintf(stderr, "checkasm: using random seed %u\n", seed);
>      av_lfg_init(&checkasm_lfg, seed);
>  
> +    if (state.bench_pattern)
> +        fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs));
> +
>      check_cpu_flag(NULL, 0);
>      for (i = 0; cpus[i].flag; i++)
>          check_cpu_flag(cpus[i].name, cpus[i].flag);

LGTM.

-- 
jd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

[Lynne via ffmpeg-devel]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 936 bytes --]

On 21/05/2024 17:07, J. Dekker wrote:
> 
> Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> writes:
> 
>> Helps make sense of the possible noise in the results.
>> ---
>>   tests/checkasm/checkasm.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
>> index 669f2be9c1..b1c175b95d 100644
>> --- a/tests/checkasm/checkasm.c
>> +++ b/tests/checkasm/checkasm.c
>> @@ -892,6 +892,9 @@ int main(int argc, char *argv[])
>>       fprintf(stderr, "checkasm: using random seed %u\n", seed);
>>       av_lfg_init(&checkasm_lfg, seed);
>>   
>> +    if (state.bench_pattern)
>> +        fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs));
>> +
>>       check_cpu_flag(NULL, 0);
>>       for (i = 0; cpus[i].flag; i++)
>>           check_cpu_flag(cpus[i].name, cpus[i].flag);
> 
> LGTM.
> 

Thanks, pushed

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".