From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B177D432DC for ; Tue, 21 May 2024 02:47:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02F7168D239; Tue, 21 May 2024 05:47:04 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9BE9368D0A4 for ; Tue, 21 May 2024 05:46:55 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C57EFE0002 for ; Tue, 21 May 2024 02:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716259614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VMLQOZXXFNu2vwxu4avw8qy5sAi2PJUV+4NGyn+lQbo=; b=KgcKTE7AN9Kv4HNI9st2DbhcZ/x1VsrVI9eubygZw6AiiMeQe4wLBjpscK+AUqSPMKug1Q h/T4IKUeks+16KlIjf9TpwC58hNVpNBMTkjqko353Kola1jN4T0bkJFZEnwCSQppjcRqCa o7QyluvryVQD9kWCWr7+OGj+h0VWQaoeiZ8fmu0yq9jRpT7UJGV5Rbq4lZq/2ZicokU33u tMboWrCPbZxSyrn01JqOsYzHYdvxClMmM2ICHhsRCmq7Day/mIrND/7vX/g4M8iPzxMtn8 2rWREBcCSbtdNcitCId+xaJt5kFV0WhImVhFdL+pKBvyIHXMBINmlKqXtyCcrA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 21 May 2024 04:46:47 +0200 Message-ID: <20240521024652.1006233-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240521024652.1006233-1-michael@niedermayer.cc> References: <20240521024652.1006233-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/7] avutil/tests/dict: Check av_dict_set() before get for failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Failure is possible due to strdup() Fixes: CID1516764 Dereference null return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/tests/dict.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/tests/dict.c b/libavutil/tests/dict.c index e45bc220cb3..21368203ce2 100644 --- a/libavutil/tests/dict.c +++ b/libavutil/tests/dict.c @@ -150,12 +150,15 @@ int main(void) //valgrind sensible test printf("\nTesting av_dict_set() with existing AVDictionaryEntry.key as key\n"); - av_dict_set(&dict, "key", "old", 0); + if (av_dict_set(&dict, "key", "old", 0) < 0) + return 1; e = av_dict_get(dict, "key", NULL, 0); - av_dict_set(&dict, e->key, "new val OK", 0); + if (av_dict_set(&dict, e->key, "new val OK", 0) < 0) + return 1; e = av_dict_get(dict, "key", NULL, 0); printf("%s\n", e->value); - av_dict_set(&dict, e->key, e->value, 0); + if (av_dict_set(&dict, e->key, e->value, 0) < 0) + return 1; e = av_dict_get(dict, "key", NULL, 0); printf("%s\n", e->value); av_dict_free(&dict); -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".