From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 818C84888F for ; Sun, 19 May 2024 23:19:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E55A68A7ED; Mon, 20 May 2024 02:19:29 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38CBA68C3F6 for ; Mon, 20 May 2024 02:19:22 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1741460002 for ; Sun, 19 May 2024 23:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716160761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KfQHpEydNuhCOefRCoVV+Wo2ku0r7rX8u02QbfN1d6k=; b=jEzx1FVRueUfVUNxcYa2APhkeQn3UhelM27k6s9UyLm+V2Q5LEce8VrR2iF1XpWE9PPlSj wmIPsB/ITQ244DGcqb0BN90CbRyZGNYNaRWa6jx70vl+0Hpaf8beFzTHCCG3bCyByOG+eo fuaPvjyB6KNRT58nEnUphf+oPOKfaUuLfwiJL8Rj+eQ8UhmfZ7GZvfsy5NlKgwSHKXsnxn /cHXEHcMYoP5+NkSHROK2lY1SLP/bJFjwYxexXWxMWGISgHch7yDpAUNUAJp03nnzpPVUb 3feLrXTQ6KwLWJ9WrOyoOFJvlZr3zWGiLOLgNtbsf1TPcUqD/qsUTqIzNwVrLw== Date: Mon, 20 May 2024 01:19:20 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240519231920.GR2821752@pb2> References: <20240519165444.829271-1-dev@lynne.ee> <20240519165444.829271-9-dev@lynne.ee> MIME-Version: 1.0 In-Reply-To: <20240519165444.829271-9-dev@lynne.ee> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6814521311563942974==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6814521311563942974== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N+qDRRsDvMgizTft" Content-Disposition: inline --N+qDRRsDvMgizTft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote: > This commit adds a decoder for the frequency-domain part of USAC. >=20 > What works: > - Mono > - Stereo (no prediction) > - Stereo (mid/side coding) > - Stereo (complex prediction) >=20 > What's left: > - Speech coding >=20 > Known issues: > - Desync with certain sequences > - Preroll crossover missing (shouldn't matter, bitrate adaptation only) > --- > libavcodec/aac/Makefile | 3 +- > libavcodec/aac/aacdec.c | 188 +-- > libavcodec/aac/aacdec.h | 187 +++ > libavcodec/aac/aacdec_ac.c | 208 ++++ > libavcodec/aac/aacdec_ac.h | 54 + > libavcodec/aac/aacdec_dsp_template.c | 4 +- > libavcodec/aac/aacdec_latm.h | 14 +- > libavcodec/aac/aacdec_lpd.c | 198 ++++ > libavcodec/aac/aacdec_lpd.h | 33 + > libavcodec/aac/aacdec_usac.c | 1587 ++++++++++++++++++++++++++ > libavcodec/aac/aacdec_usac.h | 39 + > libavcodec/aactab.c | 42 + > libavcodec/aactab.h | 10 + > 13 files changed, 2491 insertions(+), 76 deletions(-) > create mode 100644 libavcodec/aac/aacdec_ac.c > create mode 100644 libavcodec/aac/aacdec_ac.h > create mode 100644 libavcodec/aac/aacdec_lpd.c > create mode 100644 libavcodec/aac/aacdec_lpd.h > create mode 100644 libavcodec/aac/aacdec_usac.c > create mode 100644 libavcodec/aac/aacdec_usac.h seems to break fate make -j32 fate-source TEST source --- ./tests/ref/fate/source 2024-05-20 01:14:59.407222202 +0200 +++ tests/data/fate/source 2024-05-20 01:17:32.661142354 +0200 @@ -23,6 +25,7 @@ compat/djgpp/math.h compat/float/float.h compat/float/limits.h +libavcodec/aac/aacdec_ac.h libavcodec/bitstream_template.h tools/decode_simple.h Use of av_clip() where av_clip_uintp2() could be used: Test source failed. Look at tests/data/fate/source.err for details. make: *** [tests/Makefile:311: fate-source] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire --N+qDRRsDvMgizTft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkqI8QAKCRBhHseHBAsP q2sXAJ4wV7gLEY/FHayEGGqQEHDezF2XMwCgl5YjRZBceNx0kBRgnjZYEyRmeDA= =Ajod -----END PGP SIGNATURE----- --N+qDRRsDvMgizTft-- --===============6814521311563942974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6814521311563942974==--