Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1136 bytes --]

On Sun, May 19, 2024 at 06:05:20PM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Helps: CID1548380 Uninitialized scalar variable
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/rv34.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c
> > index 23a570bb807..4ce0cc58d05 100644
> > --- a/libavcodec/rv34.c
> > +++ b/libavcodec/rv34.c
> > @@ -98,6 +98,8 @@ static av_cold void rv34_gen_vlc_ext(const uint8_t *bits, int size, VLC *vlc,
> >      uint16_t cw[MAX_VLC_SIZE];
> >      int maxbits;
> >  
> > +    av_assert0(size > 0);
> > +
> >      for (int i = 0; i < size; i++)
> >          counts[bits[i]]++;
> >  
> 
> An av_assert0 just because of Coverity? Why not av_assert1?

the function is av_cold, so it doesnt really matter i think
but changed to av_assert1 locally

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".