From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C2B6497BC for ; Sun, 19 May 2024 19:44:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EED3C68D01B; Sun, 19 May 2024 22:44:50 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 52F3B68CADA for ; Sun, 19 May 2024 22:44:44 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 86C30240004 for ; Sun, 19 May 2024 19:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716147883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x3ZYPkJGmsk63S9racs6OWjHjK5jg9a6nJZQgbRP354=; b=GexkkvxktR5EEAf2o8SfPxALvuu627SBnpjrdtPZoNjA2lZDqRDdPMU2RlUQ1vdkXpkrnT xqp7slL5CUBUM+YmYuSNe36RkzRK0/aZQLFlJnMNnVjZIILI26L2H/cTBpV+Qp3EcdRUnC zts7FZwCmtUoea/MDXEvLFvrxe4zJKPm8sDyd94LDkA2o1w5k70bfLS2CxmEArz3AS8NiB gqezgw429wwygHL7OYu65CZsQYx2K0Us5AA9tjLStkD/RNH2yj7ZaNbsZ4KMk1K33Yvsxo 1tOCtX5jAHmi97XLkeeZat4mGPmZ6Kur9Ijc5m3phe0kh9jTeInpIqflCZE1kg== Date: Sun, 19 May 2024 21:44:42 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240519194442.GL2821752@pb2> References: <20240518035743.766552-1-michael@niedermayer.cc> <20240518035743.766552-9-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7359653389774461191==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7359653389774461191== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GeDkoc8jIzHasOdk" Content-Disposition: inline --GeDkoc8jIzHasOdk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 18, 2024 at 06:33:12PM +1000, Peter Ross wrote: > On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > > Fixes: CID1452425 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp3.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > >=20 > > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > > index 09527607767..d03a1c9dbc1 100644 > > --- a/libavcodec/vp3.c > > +++ b/libavcodec/vp3.c > > @@ -2001,8 +2001,7 @@ static int vp4_mc_loop_filter(Vp3DecodeContext *s= , int plane, int motion_x, int > > x_offset =3D (-(x + 2) & 7) + 2; > > y_offset =3D (-(y + 2) & 7) + 2; > > =20 > > - if (x_offset > 8 + x_subpel && y_offset > 8 + y_subpel) > > - return 0; > > + av_assert1(!(x_offset > 8 + x_subpel && y_offset > 8 + y_subpe= l)); > > =20 >=20 > ok will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --GeDkoc8jIzHasOdk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkpWqgAKCRBhHseHBAsP q51NAJ4pDGEB86+DtJBNc/zXd/IHT4igXgCbBqSOhV+iazzZK2F6UTfBJw5G0mQ= =PVBf -----END PGP SIGNATURE----- --GeDkoc8jIzHasOdk-- --===============7359653389774461191== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7359653389774461191==--