From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E2EA48878 for ; Sun, 19 May 2024 19:40:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 536FE68D01E; Sun, 19 May 2024 22:40:46 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5A9868C1B3 for ; Sun, 19 May 2024 22:40:39 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4E931E0002 for ; Sun, 19 May 2024 19:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716147639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fPccAk0YY6Qt4NuJdLQciwTuMcQuvF4nWQwDBTfYVFY=; b=cEdtlueJIB75tynbAT4Her3O/vKxUuWGoVlLTD71cp6cZsM0w0D4rlwC2TzYGyTdjihIgz MXSPQGyodOMRBvCOU3LNU2pAQwP8rWQ4fKxNiLPVY1QIZB8sX75zqmBTJi63q7KAeW/i+S EmLCnVsE+tWtkx8i6g8+QuTFlXaAHq/i4+5MXYLNgwiCB0h69R7zr3cfVzGSaB4P+kvepe IWYM9x1X3ddTPBNXbLuy9R0ECEDW2QN3ZI3C/HHK+ISDtShtmgUe171QISNDNdcv5eE6Rq 2TigmUjmnteGhIbWIjjlm4WrB2dhMXhkaR6uMRnbWAHx9W4tq5q/IHquECo+iQ== Date: Sun, 19 May 2024 21:40:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240519194038.GJ2821752@pb2> References: <20240519024915.1944150-1-michael@niedermayer.cc> <20240519024915.1944150-7-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1042557596256968856==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1042557596256968856== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KjX7LgAomYr70Ka9" Content-Disposition: inline --KjX7LgAomYr70Ka9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 19, 2024 at 10:28:49PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:50=E2=80=AFAM Michael Niedermayer > wrote: >=20 > > This might not be needed for correctness but it could > > help general reproducability of issues > > > > Related to: CID1560037 Uninitialized scalar variable > > Related to: CID1560044 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vvc/mvs.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/vvc/mvs.c b/libavcodec/vvc/mvs.c > > index fe7d9234603..521cf96a896 100644 > > --- a/libavcodec/vvc/mvs.c > > +++ b/libavcodec/vvc/mvs.c > > @@ -411,7 +411,7 @@ void ff_vvc_store_sb_mvs(const VVCLocalContext *lc, > > PredictionUnit *pu) > > const int sbw =3D cu->cb_width / mi->num_sb_x; > > const int sbh =3D cu->cb_height / mi->num_sb_y; > > SubblockParams params[2]; > > - MvField mvf; > > + MvField mvf =3D {0}; > > > > mvf.pred_flag =3D mi->pred_flag; > > mvf.bcw_idx =3D mi->bcw_idx; > > @@ -504,7 +504,7 @@ void ff_vvc_store_mvf(const VVCLocalContext *lc, co= nst > > MvField *mvf) > > void ff_vvc_store_mv(const VVCLocalContext *lc, const MotionInfo *mi) > > { > > const CodingUnit *cu =3D lc->cu; > > - MvField mvf; > > + MvField mvf =3D {0}; > > > > mvf.hpel_if_idx =3D mi->hpel_if_idx; > > mvf.bcw_idx =3D mi->bcw_idx; > > -- > > 2.45.1 > > > both "mvf.ciip_flag =3D 0" are not needed if we set mvf to 0 locally changed thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle --KjX7LgAomYr70Ka9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkpVtgAKCRBhHseHBAsP q7rWAJ9c5hGHZSmLJbkGY3A8HGwkykqiLACfX8xDoKGYJLddUJojEUkugFkDSxA= =LZ6b -----END PGP SIGNATURE----- --KjX7LgAomYr70Ka9-- --===============1042557596256968856== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1042557596256968856==--