From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DEE11482BC for ; Sun, 19 May 2024 19:38:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C21668CFFE; Sun, 19 May 2024 22:38:01 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF18A68C733 for ; Sun, 19 May 2024 22:37:54 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1819FE0002 for ; Sun, 19 May 2024 19:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716147474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C0RhS9tt6N+jg/epYNj8dMVSwSigyq6SDkGs7WOyBAU=; b=e7lFiueJiHgLADTrdUTH5rMDLMtV+RvOvW8QlyC4znIoOZk5JMl5cbnRtRLrVnpENx0vUI 3HRO3AUCb0F07qhH/DgS81GIy3DpEsL9+tEs6kJOPLpMNdtPx0haD5N0xcaToEIYe2y62x 5y52w9Fbsg2VUrn32B9YYAnLnKSvtUPpsDW6NCGCzCJ0nB/sIDHxu58WK+js5YECOL2yRc UdK3fCljGjqK78YE33+O80zRSsCz8/ilQD/7XjNiPuUHAH4zj4siVzg9VYm3PlcMx6hzBU wpoWYEjiEPo+MaxDoHmMzYGj56CZXoMFlV3YivYJRCw/pZ5y9B3ScT0akJHcgw== Date: Sun, 19 May 2024 21:37:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240519193753.GH2821752@pb2> References: <20240519024915.1944150-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0727168536884307763==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0727168536884307763== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FUaywKC54iCcLzqT" Content-Disposition: inline --FUaywKC54iCcLzqT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 19, 2024 at 01:18:09PM +1000, Peter Ross wrote: > On Sun, May 19, 2024 at 04:49:07AM +0200, Michael Niedermayer wrote: > > Fixes: CID1516090 Unchecked return value > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vqcdec.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/vqcdec.c b/libavcodec/vqcdec.c > > index 5c6cab3c1ab..bb69844327d 100644 > > --- a/libavcodec/vqcdec.c > > +++ b/libavcodec/vqcdec.c > > @@ -147,10 +147,13 @@ static int decode_vectors(VqcContext * s, const u= int8_t * buf, int size, int wid > > GetBitContext gb; > > uint8_t * vectors =3D s->vectors; > > uint8_t * vectors_end =3D s->vectors + (width * height * 3) / 2; > > + int ret; > > =20 > > memset(vectors, 0, 3 * width * height / 2); > > =20 > > - init_get_bits8(&gb, buf, size); > > + ret =3D init_get_bits8(&gb, buf, size); > > + if (ret < 0) > > + return ret; > > =20 > > for (int i =3D 0; i < 3 * width * height / 2 / 32; i++) { > > uint8_t * dst =3D vectors; >=20 > ok will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras --FUaywKC54iCcLzqT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkpVDgAKCRBhHseHBAsP q7T6AJ9wSpszIFIXoa0Qxhtm7pOxVb3+fwCfYjMq4O1Zxh+KKknaW5FlM3/+iuo= =5z53 -----END PGP SIGNATURE----- --FUaywKC54iCcLzqT-- --===============0727168536884307763== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0727168536884307763==--