Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 9/9] avcodec/wavpackenc: Use unsigned for potential 31bit shift
Date: Sun, 19 May 2024 04:49:15 +0200
Message-ID: <20240519024915.1944150-9-michael@niedermayer.cc> (raw)
In-Reply-To: <20240519024915.1944150-1-michael@niedermayer.cc>

Fixes: CID1465481 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/wavpackenc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c
index ba0371592d9..e99ab951d41 100644
--- a/libavcodec/wavpackenc.c
+++ b/libavcodec/wavpackenc.c
@@ -1979,7 +1979,7 @@ static void encode_flush(WavPackEncodeContext *s)
                 put_bits(pb, 31, 0x7FFFFFFF);
                 cbits -= 31;
             } else {
-                put_bits(pb, cbits, (1 << cbits) - 1);
+                put_bits(pb, cbits, (1U << cbits) - 1);
                 cbits = 0;
             }
         } while (cbits);
@@ -2008,7 +2008,7 @@ static void encode_flush(WavPackEncodeContext *s)
                     put_bits(pb, 31, 0x7FFFFFFF);
                     cbits -= 31;
                 } else {
-                    put_bits(pb, cbits, (1 << cbits) - 1);
+                    put_bits(pb, cbits, (1U << cbits) - 1);
                     cbits = 0;
                 }
             } while (cbits);
-- 
2.45.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-05-19  2:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-19  2:49 [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure Michael Niedermayer
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 2/9] avcodec/vvc/ctu: Simplify code at the end of pred_mode_decode() Michael Niedermayer
2024-07-12 21:24   ` Michael Niedermayer
2024-07-13  2:06   ` Nuo Mi
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag Michael Niedermayer
2024-05-19 14:40   ` Nuo Mi
2024-05-19 19:27     ` Michael Niedermayer
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 4/9] avcodec/vvc/ctu: Remove dead ret check Michael Niedermayer
2024-07-02 18:35   ` Michael Niedermayer
2024-07-03 12:44     ` Nuo Mi
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 5/9] avcodec/vvc/dec: Remove constant eos_at_start Michael Niedermayer
2024-07-02 18:34   ` Michael Niedermayer
2024-07-03 12:44     ` Nuo Mi
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure Michael Niedermayer
2024-05-19 14:31   ` Nuo Mi
2024-05-19 19:39     ` Michael Niedermayer
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf Michael Niedermayer
2024-05-19 14:28   ` Nuo Mi
2024-05-19 19:40     ` Michael Niedermayer
2024-05-19  2:49 ` [FFmpeg-devel] [PATCH 8/9] avcodec/wavpack: Remove dead assignments Michael Niedermayer
2024-05-19  2:49 ` Michael Niedermayer [this message]
2024-06-02 19:08   ` [FFmpeg-devel] [PATCH 9/9] avcodec/wavpackenc: Use unsigned for potential 31bit shift Michael Niedermayer
2024-05-19  3:18 ` [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure Peter Ross
2024-05-19 19:37   ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240519024915.1944150-9-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git