[FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

* [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param
@ 2024-05-18 16:11 Marton Balint
  2024-05-18 16:11 ` [FFmpeg-devel] [PATCH 2/5] doc/ffmpeg: document -channel_layout/ch_layout options Marton Balint
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Marton Balint @ 2024-05-18 16:11 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Marton Balint

The code only set the channel layout of the AVFormatContext, so the user could
not override the channel layout if the demuxer did not have such parameter.
Let's set the specified channel layouts as codec options as well.

Fixes ticket #11016.

A regression since 639c2f00497257cb60ecaeeac1aacfa80df3be06.

Signed-off-by: Marton Balint <cus@passwd.hu>
---
 doc/ffmpeg.texi        |  7 ++++---
 fftools/ffmpeg_demux.c | 46 +++++++++++++++++++++++++-----------------
 2 files changed, 32 insertions(+), 21 deletions(-)

diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index da37e3ad37..83db6584fd 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -1689,9 +1689,10 @@ demuxers and is mapped to the corresponding demuxer options.
 @item -aq @var{q} (@emph{output})
 Set the audio quality (codec-specific, VBR). This is an alias for -q:a.
 @item -ac[:@var{stream_specifier}] @var{channels} (@emph{input/output,per-stream})
-Set the number of audio channels. For output streams it is set by
-default to the number of input audio channels. For input streams
-this option only makes sense for audio grabbing devices and raw demuxers
+Set the number of audio channels. For output streams it is set by default to
+the number of input audio channels. For input streams it overrides the number
+of channels if the decoder allows it. When used without a stream specifier it
+also sets the input channel count for audio grabbing devices and raw demuxers
 and is mapped to the corresponding demuxer options.
 @item -an (@emph{input/output})
 As an input option, blocks all audio streams of a file from being filtered or
diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
index cba63dab5f..6e23079ceb 100644
--- a/fftools/ffmpeg_demux.c
+++ b/fftools/ffmpeg_demux.c
@@ -1524,6 +1524,33 @@ static Demuxer *demux_alloc(void)
     return d;
 }
 
+static int set_input_ch_layout_opts(const OptionsContext *o)
+{
+    /* "ch_layout" is only a valid format option for some formats, but we set
+     * it anyway, because it is also a codec option and we don't report
+     * unconsumed format options if they are codec options as well. */
+    for (int i = 0; i < o->audio_channels.nb_opt; i++) {
+        char val[32];
+        char *spec = o->audio_channels.opt[i].specifier;
+        char *key = av_asprintf("ch_layout%s%s", spec[0] ? ":" : "", spec);
+        if (!key)
+            return AVERROR(ENOMEM);
+        snprintf(val, sizeof(val), "%dC", o->audio_channels.opt[i].u.i);
+        av_dict_set(&o->g->format_opts, key, val, 0);
+        av_dict_set(&o->g->codec_opts,  key, val, AV_DICT_DONT_STRDUP_KEY);
+    }
+    for (int i = 0; i < o->audio_ch_layouts.nb_opt; i++) {
+        char *val = o->audio_ch_layouts.opt[i].u.str;
+        char *spec = o->audio_ch_layouts.opt[i].specifier;
+        char *key = av_asprintf("ch_layout%s%s", spec[0] ? ":" : "", spec);
+        if (!key)
+            return AVERROR(ENOMEM);
+        av_dict_set(&o->g->format_opts, key, val, 0);
+        av_dict_set(&o->g->codec_opts,  key, val, AV_DICT_DONT_STRDUP_KEY);
+    }
+    return 0;
+}
+
 int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
 {
     Demuxer   *d;
@@ -1592,24 +1619,6 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
     if (o->audio_sample_rate.nb_opt) {
         av_dict_set_int(&o->g->format_opts, "sample_rate", o->audio_sample_rate.opt[o->audio_sample_rate.nb_opt - 1].u.i, 0);
     }
-    if (o->audio_channels.nb_opt) {
-        const AVClass *priv_class;
-        if (file_iformat && (priv_class = file_iformat->priv_class) &&
-            av_opt_find(&priv_class, "ch_layout", NULL, 0,
-                        AV_OPT_SEARCH_FAKE_OBJ)) {
-            char buf[32];
-            snprintf(buf, sizeof(buf), "%dC", o->audio_channels.opt[o->audio_channels.nb_opt - 1].u.i);
-            av_dict_set(&o->g->format_opts, "ch_layout", buf, 0);
-        }
-    }
-    if (o->audio_ch_layouts.nb_opt) {
-        const AVClass *priv_class;
-        if (file_iformat && (priv_class = file_iformat->priv_class) &&
-            av_opt_find(&priv_class, "ch_layout", NULL, 0,
-                        AV_OPT_SEARCH_FAKE_OBJ)) {
-            av_dict_set(&o->g->format_opts, "ch_layout", o->audio_ch_layouts.opt[o->audio_ch_layouts.nb_opt - 1].u.str, 0);
-        }
-    }
     if (o->frame_rates.nb_opt) {
         const AVClass *priv_class;
         /* set the format-level framerate option;
@@ -1626,6 +1635,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
     }
     if (o->frame_pix_fmts.nb_opt)
         av_dict_set(&o->g->format_opts, "pixel_format", o->frame_pix_fmts.opt[o->frame_pix_fmts.nb_opt - 1].u.str, 0);
+    ret = set_input_ch_layout_opts(o);
 
     video_codec_name    = opt_match_per_type_str(&o->codec_names, 'v');
     audio_codec_name    = opt_match_per_type_str(&o->codec_names, 'a');
-- 
2.35.3

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread