From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 48A0A487A9 for ; Sat, 18 May 2024 00:25:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2FFDC68D232; Sat, 18 May 2024 03:25:51 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 040E068CF84 for ; Sat, 18 May 2024 03:25:44 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DDA131BF203 for ; Sat, 18 May 2024 00:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715991944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LTkMxNeRVJ8N1WSqqlPinNmBFq2osEcQmeoteJSYJi0=; b=TqaSl1H+zmNlnZnYqFNVRzqyywvMT/33I+TrxPAzPkawxcHakfDIS+6r/NXPJTlWzf3zAi C/hdo6cVG51PwfSCkPMHLWI4OgXoQXAMr3TMCOUTTH0PRoPOPSkFYXiM2nQDGOIFedWuqB 3m9Fr2H2Q2GwJ0xWmkIwwaETiiOYwucnTNydglS4CN+1YmDJpOiyCE7fi6mpIqpUxJz8Cs sR7jCUhTdBAFJ2b/kVcDJsRiq4mfQDjPHDYvvx8avO3ljpq157f2/SDGZNTm8O9BNotp/p hA6nyBQkaqn67gJ4T6ONdPDUmupC5CVdLzmnnRH1V0PVnnv9g5FRRRs6EFf/vA== Date: Sat, 18 May 2024 02:25:42 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240518002542.GV6420@pb2> References: <20220524000615.5264-1-michael@niedermayer.cc> <20220525155312.GZ396728@pb2> MIME-Version: 1.0 In-Reply-To: <20220525155312.GZ396728@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3932226830710420452==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3932226830710420452== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2+/zqyMe7n3LNYRv" Content-Disposition: inline --2+/zqyMe7n3LNYRv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 25, 2022 at 05:53:12PM +0200, Michael Niedermayer wrote: > On Tue, May 24, 2022 at 08:50:51PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: CID1435168 > > >=20 > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/vc1_loopfilter.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > >=20 > > > diff --git a/libavcodec/vc1_loopfilter.c b/libavcodec/vc1_loopfilter.c > > > index 0f990cccef..ee694ede28 100644 > > > --- a/libavcodec/vc1_loopfilter.c > > > +++ b/libavcodec/vc1_loopfilter.c > > > @@ -1125,10 +1125,7 @@ static av_always_inline void vc1_b_h_intfi_loo= p_filter(VC1Context *v, uint8_t *d > > > dst =3D dest + (block_num & 2) * 4 * s->linesize + (block_nu= m & 1) * 8; > > > =20 > > > if (!(flags & RIGHT_EDGE) || !(block_num & 5)) { > > > - if (block_num > 3) > > > - v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > > - else > > > - v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > > + v->vc1dsp.vc1_h_loop_filter8(dst + 8, linesize, pq); > > > } > > > =20 > > > tt =3D ttblk[0] >> (block_num * 4) & 0xf; > >=20 > > Are you certain that the current code is actually correct or whether > > something else was intended? >=20 > iam not certain no but the vc1_b_v_intfi_loop_filter() function also > treats luma and chroma the same >=20 > if(!(flags & BOTTOM_EDGE) || block_num < 2) > v->vc1dsp.vc1_v_loop_filter8(dst + 8 * linesize, linesize, pq); >=20 > this is just the matching function for horizontal instead of vertical >=20 > also whan looking at the 4x4 4x8 and 8x4 cases i see no difference > between horizontal and vertical for intfi. But ultimately yes of course > it could be buggy and something else could be correct. >=20 > but if i replace this by an abort() > make: *** [fate-vc1_sa10143] Error 134 > make: *** [fate-vc1_ilaced_twomv] Error 134 >=20 > Fate fails, so it should be tested will apply this unless someone has some further insight in this or objection as i just run into this again thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to community college in order to be able to afford settlements. -- The RIAA --2+/zqyMe7n3LNYRv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkf1gAAKCRBhHseHBAsP q/6AAKCN7o/zrVMcAi34iv2Kf0VK3ID+pQCcDpMkPysr2nAS6fNuFAIl+Gi17f8= =K+3U -----END PGP SIGNATURE----- --2+/zqyMe7n3LNYRv-- --===============3932226830710420452== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3932226830710420452==--