Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/5] avcodec/scpr3: unify adding 127
Date: Fri, 17 May 2024 01:19:29 +0200
Message-ID: <20240516231932.6950-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20240516231932.6950-1-michael@niedermayer.cc>

Untested, i have no testcase nor does fate

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/scpr3.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c
index 5271717ac79..79106ddcff8 100644
--- a/libavcodec/scpr3.c
+++ b/libavcodec/scpr3.c
@@ -42,7 +42,7 @@ static void renew_table3(uint32_t nsym, uint32_t *cntsum,
         freqs[d] = b;
         freqs1[d] = a;
         cnts[d] = c;
-        for (int q = a + 128 - 1 >> 7, f = (a + b - 1 >> 7) + 1; q < f; q++)
+        for (int q = a + 127 >> 7, f = a + b + 127 >> 7; q < f; q++)
             dectab[q] = d;
 
         a += b;
@@ -232,7 +232,7 @@ static int update_model6_to_7(PixelModel3 *m)
             cnts[j] = d;
         }
         p = (e + 127) >> 7;
-        k = ((f + e - 1) >> 7) + 1;
+        k = f + e + 127 >> 7;
         if (k > FF_ARRAY_ELEMS(n.dectab))
             return AVERROR_INVALIDDATA;
         for (i = 0; i < k - p; i++)
@@ -688,10 +688,10 @@ static int update_model3_to_7(PixelModel3 *m, uint8_t value)
         n.cntsum += n.cnts[e];
         n.freqs1[e] = c;
         g = n.freqs[e];
-        f = (c + g - 1 >> 7) + 1;
+        f = c + g + 127 >> 7;
         if (f > FF_ARRAY_ELEMS(n.dectab))
             return AVERROR_INVALIDDATA;
-        for (q = c + 128 - 1 >> 7; q < f; q++) {
+        for (q = c + 127 >> 7; q < f; q++) {
             n.dectab[q] = e;
         }
         c += g;
@@ -760,7 +760,7 @@ static int decode_value3(SCPRContext *s, uint32_t max, uint32_t *cntsum,
             freqs1[i] = e;
             g = (c + 127) >> 7;
             c += e;
-            q = ((c - 1) >> 7) + 1;
+            q = c + 127 >> 7;
             if (q > g) {
                 for (int j = 0; j < q - g; j++)
                     dectable[j + g] = i;
-- 
2.43.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-16 23:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 23:19 [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext() Michael Niedermayer
2024-05-16 23:19 ` Michael Niedermayer [this message]
2024-05-16 23:19 ` [FFmpeg-devel] [PATCH 3/5] avcodec/scpr3: Check add_dec() for failure Michael Niedermayer
2024-05-16 23:19 ` [FFmpeg-devel] [PATCH 4/5] avcodec/sga: Check non constant init_get_bits8() Michael Niedermayer
2024-05-17  7:53   ` Andreas Rheinhardt
2024-05-17 21:01     ` Michael Niedermayer
2024-05-16 23:19 ` [FFmpeg-devel] [PATCH 5/5] avcodec/tests/dct: Use 64bit in intermediate for error computation Michael Niedermayer
2024-05-19 16:05 ` [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext() Andreas Rheinhardt
2024-05-19 19:48   ` Michael Niedermayer
2024-06-02 19:14 ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516231932.6950-2-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git