From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: [FFmpeg-devel] [PATCH 0/8] aacdec: add a native xHE-AAC decoder
Date: Thu, 16 May 2024 12:08:10 +0200
Message-ID: <20240516100818.246162-1-dev@lynne.ee> (raw)
This commit adds a decoder for the frequency-domain part of USAC.
What works:
- Mono
- Stereo (no prediction)
- Stereo (mid/side coding)
What doesn't:
- Preroll decoding (every single decoder seems faulty or weird?)
- Complex stereo prediction
Known issues:
- Spec incompliance due to the spec being flat-out wrong in 11 cases.
- Spec compliance due to the spec being woefully underspecified.
- Lack of robustness
- A single memory leak in packet fragmentation.
I've reached out to the spec authors to get a conformation.
I'm reasonably happy with the way I integrated it to send it
off for review ahead of spec issue clarification.
Lynne (8):
aacdec: move from scalefactor ranged arrays to flat arrays
aacdec: expose channel layout related functions
aacdec: expose decode_tns
aacdec_dsp: implement 768-point transform and windowing
aactab: add deemphasis tables for USAC
aactab: add tables for the new USAC arithmetic coder
aactab: add new scalefactor offset tables for 96/768pt windows
aacdec: add a decoder for AAC USAC (xHE-AAC)
libavcodec/aac/Makefile | 3 +-
libavcodec/aac/aacdec.c | 364 ++++----
libavcodec/aac/aacdec.h | 211 ++++-
libavcodec/aac/aacdec_ac.c | 224 +++++
libavcodec/aac/aacdec_ac.h | 54 ++
libavcodec/aac/aacdec_dsp_template.c | 162 ++--
libavcodec/aac/aacdec_fixed.c | 2 +
libavcodec/aac/aacdec_float.c | 4 +
libavcodec/aac/aacdec_latm.h | 14 +-
libavcodec/aac/aacdec_lpd.c | 192 ++++
libavcodec/aac/aacdec_lpd.h | 33 +
libavcodec/aac/aacdec_usac.c | 1230 ++++++++++++++++++++++++++
libavcodec/aac/aacdec_usac.h | 47 +
libavcodec/aactab.c | 523 +++++++++++
libavcodec/aactab.h | 15 +
libavcodec/sinewin_fixed_tablegen.c | 2 +
libavcodec/sinewin_fixed_tablegen.h | 4 +
17 files changed, 2850 insertions(+), 234 deletions(-)
create mode 100644 libavcodec/aac/aacdec_ac.c
create mode 100644 libavcodec/aac/aacdec_ac.h
create mode 100644 libavcodec/aac/aacdec_lpd.c
create mode 100644 libavcodec/aac/aacdec_lpd.h
create mode 100644 libavcodec/aac/aacdec_usac.c
create mode 100644 libavcodec/aac/aacdec_usac.h
--
2.43.0.381.gb435a96ce8
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-05-16 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 10:08 Lynne via ffmpeg-devel [this message]
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 1/8] aacdec: move from scalefactor ranged arrays to flat arrays Lynne via ffmpeg-devel
2024-05-16 18:30 ` Michael Niedermayer
2024-05-16 18:46 ` Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 2/8] aacdec: expose channel layout related functions Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 3/8] aacdec: expose decode_tns Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 4/8] aacdec_dsp: implement 768-point transform and windowing Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 5/8] aactab: add deemphasis tables for USAC Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 6/8] aactab: add tables for the new USAC arithmetic coder Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 7/8] aactab: add new scalefactor offset tables for 96/768pt windows Lynne via ffmpeg-devel
2024-05-16 10:08 ` [FFmpeg-devel] [PATCH 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC) Lynne via ffmpeg-devel
2024-05-16 10:26 ` Andreas Rheinhardt
2024-05-16 15:00 ` Lynne via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516100818.246162-1-dev@lynne.ee \
--to=ffmpeg-devel@ffmpeg.org \
--cc=dev@lynne.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git