From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C35654AB64 for ; Mon, 13 May 2024 21:48:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1EDC68D6AA; Tue, 14 May 2024 00:48:36 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 64CF268D601 for ; Tue, 14 May 2024 00:48:30 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8DD3640002 for ; Mon, 13 May 2024 21:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715636909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jcjdEq4auWh7lPoBG6eOreLu8xNa+8HL08L7UgKyc6o=; b=ZOcPp7Wp+Lm7hMm0SLBmhPVxyx7nwrgN78FB2A4pUoMU7ZYYPiIubmJNWNq0Kh/R0gMknc J5cnlZ6XWPy/7n8xs+XS2G6HZqI12m3glwBShw4IkuW0jAh5MPyTtuWOBUr2hCiLIW6fbT 4UJQJvwmfLKBnkwU3yNlf3JflP6jb+4df1odbmuYj1prJ6Ybk6fjrhDb384zettrZJ2BE5 BkHbIE8sd63DiKSa3HUDhPIi/HAKk6VlLIFAw8Uywc8TVjT5YTdNrKHK94Ihn8Yy/EUSAK rP9isS6tq6D1evnGctgisRTgY5x9L8A4fMSbvbDvAJRklyJEsT7vhzeo3K9WGg== Date: Mon, 13 May 2024 23:48:28 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240513214828.GI6420@pb2> References: <20240510140705.443047-1-michael@niedermayer.cc> <20240510140705.443047-2-michael@niedermayer.cc> <78cce1dcbc1f6a5f1dd0799a079c89adf8ae5944.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <78cce1dcbc1f6a5f1dd0799a079c89adf8ae5944.camel@haerdin.se> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6905171454344368174==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6905171454344368174== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jAxWcaKWq9hd3DWq" Content-Disposition: inline --jAxWcaKWq9hd3DWq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 10:35:44AM +0200, Tomas H=E4rdin wrote: > fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer: > > Fixes: CID1460979 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavcodec/jpeg2000dec.c | 3 --- > > =A01 file changed, 3 deletions(-) > >=20 > > diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c > > index 28bf6be2fef..135537b52fb 100644 > > --- a/libavcodec/jpeg2000dec.c > > +++ b/libavcodec/jpeg2000dec.c > > @@ -835,9 +835,6 @@ static int get_tlm(Jpeg2000DecoderContext *s, int > > n) > > =A0=A0=A0=A0=A0=A0=A0=A0 case 2: > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 bytestream2_get_be16(&s->g); > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 break; > > -=A0=A0=A0=A0=A0=A0=A0 case 3: > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 bytestream2_get_be32(&s->g); > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 break; >=20 > Double-checked T.800 table A.34 and indeed ST =3D=3D 3 is invalid (which = is > also checked just above). So looks OK. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --jAxWcaKWq9hd3DWq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkKKowAKCRBhHseHBAsP q479AJ9uAYYyvpMWwMPKrUeh0am+XqQsewCdFjyOiU/s17js1QfgcAqlexIuqA8= =tkCB -----END PGP SIGNATURE----- --jAxWcaKWq9hd3DWq-- --===============6905171454344368174== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6905171454344368174==--