From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A32E4AB5A for ; Mon, 13 May 2024 20:09:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7E8668D6E4; Mon, 13 May 2024 23:09:40 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2AACC68D41D for ; Mon, 13 May 2024 23:09:34 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 808251BF203 for ; Mon, 13 May 2024 20:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715630973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XjcwKsljqZuPCYFtzSNjDWNMeu8+PaIj7UJWv9Znpzs=; b=WodygZVm5XN1xAsRs6sKGqrMs0qFFdAgL7CfSVIH7COkZ0wYGTx00K6S7YaTasN3OM84kM tqykLM7/a9qGK9EMl1a1QsUDne9U76gHz0mgGHnLOqAWrjI2wQCgfTI++3XGdNxfSTRvC8 lf26oPL0ie1KcKMqrPPzGEEvpi48wOvLf8Yu93rYq5I+7IelMPgEjjf7X5LDQYgGT0DFqL j7aSny/cUXmh/c4ToSYRLaPXI7idy/4Vcq0BRXEzoIplTGNsUFeUGbpQA8zXNRgmKhL7n2 vwjExFaS9r8ViJND8GTiks5eW/iT686ldwVhxBy2K4HQn+QOdiyd/9L7146Ekg== Date: Mon, 13 May 2024 22:09:32 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240513200932.GF6420@pb2> References: <20240506012307.807589-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5688712952951577288==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5688712952951577288== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mMFxY7PorxIA15Pu" Content-Disposition: inline --mMFxY7PorxIA15Pu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 09:04:34AM +0300, R=E9mi Denis-Courmont wrote: >=20 >=20 > Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer a =E9crit=A0: > >Fixes: CID1439574 Dereference after null check >=20 > If SPS is guaranteed to be non-NULL, there should probably be an assertio= n to document it, and it should be *before* that alleged dereference (which= is not visible in the patch context). why ? I mean why would sps require an assert*(sps) but the overwhelming majority of pointers, we just dereference without assert before them ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your enemies, for they first find out your faults. -- Antisthenes --mMFxY7PorxIA15Pu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZkJzeQAKCRBhHseHBAsP q95gAKCJ1i5HfFk2d7aqIzVYDxGIyK/YvwCeJ+Qq+pth3Ie6oaT1Nak2rtHgg+s= =JbNH -----END PGP SIGNATURE----- --mMFxY7PorxIA15Pu-- --===============5688712952951577288== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5688712952951577288==--