[FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Michael Niedermayer]

Fixes: CID1439574 Dereference after null check

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/h264_slice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index 90d37f60848..ce2c4caca1b 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -1396,7 +1396,7 @@ static int h264_field_start(H264Context *h, const H264SliceContext *sl,
 
     sps = h->ps.sps;
 
-    if (sps && sps->bitstream_restriction_flag &&
+    if (sps->bitstream_restriction_flag &&
         h->avctx->has_b_frames < sps->num_reorder_frames) {
         h->avctx->has_b_frames = sps->num_reorder_frames;
     }
-- 
2.43.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 484 bytes --]

On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote:
> Fixes: CID1439574 Dereference after null check
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/h264_slice.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Kieran Kunhya]

On Mon, 13 May 2024, 02:32 Michael Niedermayer, <michael@niedermayer.cc>
wrote:

> On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote:
> > Fixes: CID1439574 Dereference after null check
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/h264_slice.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> will apply
>

I don't understand what this fixes

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Rémi Denis-Courmont]

Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
>Fixes: CID1439574 Dereference after null check

If SPS is guaranteed to be non-NULL, there should probably be an assertion to document it, and it should be *before* that alleged dereference (which is not visible in the patch context).

>
>Sponsored-by: Sovereign Tech Fund
>Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>---
> libavcodec/h264_slice.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
>index 90d37f60848..ce2c4caca1b 100644
>--- a/libavcodec/h264_slice.c
>+++ b/libavcodec/h264_slice.c
>@@ -1396,7 +1396,7 @@ static int h264_field_start(H264Context *h, const H264SliceContext *sl,
> 
>     sps = h->ps.sps;
> 
>-    if (sps && sps->bitstream_restriction_flag &&
>+    if (sps->bitstream_restriction_flag &&
>         h->avctx->has_b_frames < sps->num_reorder_frames) {
>         h->avctx->has_b_frames = sps->num_reorder_frames;
>     }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

On Mon, May 13, 2024 at 09:04:34AM +0300, Rémi Denis-Courmont wrote:
> 
> 
> Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
> >Fixes: CID1439574 Dereference after null check
> 
> If SPS is guaranteed to be non-NULL, there should probably be an assertion to document it, and it should be *before* that alleged dereference (which is not visible in the patch context).

why ?

I mean why would sps require an assert*(sps) but the overwhelming majority
of pointers, we just dereference without assert before them ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 860 bytes --]

On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote:
> On Mon, 13 May 2024, 02:32 Michael Niedermayer, <michael@niedermayer.cc>
> wrote:
> 
> > On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote:
> > > Fixes: CID1439574 Dereference after null check
> > >
> > > Sponsored-by: Sovereign Tech Fund
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > >  libavcodec/h264_slice.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > will apply
> >
> 
> I don't understand what this fixes

it is not possible for sps to be NULL in this function (see line 1424)

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

[James Almer]

On 5/13/2024 7:49 PM, Michael Niedermayer wrote:
> On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote:
>> On Mon, 13 May 2024, 02:32 Michael Niedermayer, <michael@niedermayer.cc>
>> wrote:
>>
>>> On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote:
>>>> Fixes: CID1439574 Dereference after null check
>>>>
>>>> Sponsored-by: Sovereign Tech Fund
>>>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>>>> ---
>>>>   libavcodec/h264_slice.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> will apply
>>>
>>
>> I don't understand what this fixes
> 
> it is not possible for sps to be NULL in this function (see line 1424)

It's also passed to ff_h264_init_poc(), which expects it to not be NULL.

In any case, when the coverity issues are about something that's not a 
bug but just noise like superfluous checks, might as well use something 
like "closes" rather than "fixes".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".