[FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

[FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

[Lynne via ffmpeg-devel]

Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538.
Untested, but its assumed that unlike most of the old ARM code,
this one was still working.
---
 libavcodec/aac/aacdec_float.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/aac/aacdec_float.c b/libavcodec/aac/aacdec_float.c
index 885d824fa7..03ec264c50 100644
--- a/libavcodec/aac/aacdec_float.c
+++ b/libavcodec/aac/aacdec_float.c
@@ -79,6 +79,11 @@ static const float cce_scale[] = {
 #include "aacdec_tab.h"
 #include "libavutil/intfloat.h"
 
+#include "config.h"
+#if ARCH_ARM
+#include "libavcodec/arm/aac.h"
+#endif
+
 #ifndef VMUL2
 static inline float *VMUL2(float *dst, const float *v, unsigned idx,
                            const float *scale)
-- 
2.43.0.381.gb435a96ce8
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

[Martin Storsjö]

On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote:

> Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538.
> Untested, but its assumed that unlike most of the old ARM code,
> this one was still working.
> ---
> libavcodec/aac/aacdec_float.c | 5 +++++
> 1 file changed, 5 insertions(+)

LGTM, thanks. Tested and it does seem to pass fate successfully on arm32 
builds.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

[Lynne via ffmpeg-devel]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 509 bytes --]

On 13/05/2024 12:13, Martin Storsjö wrote:
> On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote:
> 
>> Unintentionally removed as part of 
>> 03cf10164578aed33f4d0cb5b69d63669c01a538.
>> Untested, but its assumed that unlike most of the old ARM code,
>> this one was still working.
>> ---
>> libavcodec/aac/aacdec_float.c | 5 +++++
>> 1 file changed, 5 insertions(+)
> 
> LGTM, thanks. Tested and it does seem to pass fate successfully on arm32 
> builds.
> 
> // Martin
> 

Thanks, pushed.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".