From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/libx264: Check init_get_bits8() return code Date: Fri, 10 May 2024 16:07:05 +0200 Message-ID: <20240510140705.443047-3-michael@niedermayer.cc> (raw) In-Reply-To: <20240510140705.443047-1-michael@niedermayer.cc> Fixes: CID1594529 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 2715f277f1f..e4938c54a90 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -922,7 +922,9 @@ static int set_avcc_extradata(AVCodecContext *avctx, x264_nal_t *nal, int nnal) * * +4 to skip until sps id. */ - init_get_bits8(&gbc, sps + 4, sps_nal->i_payload - 4 - 4); + ret = init_get_bits8(&gbc, sps + 4, sps_nal->i_payload - 4 - 4); + if (ret < 0) + return ret; // Skip sps id get_ue_golomb_31(&gbc); chroma_format_idc = get_ue_golomb_31(&gbc); -- 2.43.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-10 14:07 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-10 14:07 [FFmpeg-devel] [PATCH 1/3] avcodec/ilbcdec: Remove dead code Michael Niedermayer 2024-05-10 14:07 ` [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case Michael Niedermayer 2024-05-13 8:35 ` Tomas Härdin 2024-05-13 21:48 ` Michael Niedermayer 2024-05-13 8:51 ` Tomas Härdin 2024-05-13 8:59 ` Tomas Härdin 2024-05-10 14:07 ` Michael Niedermayer [this message] 2024-06-07 18:53 ` [FFmpeg-devel] [PATCH 1/3] avcodec/ilbcdec: Remove dead code Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240510140705.443047-3-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git