From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 914394809E for ; Thu, 9 May 2024 00:44:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C366A68D3C9; Thu, 9 May 2024 03:44:52 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D63B368D420 for ; Thu, 9 May 2024 03:44:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 40A53FF803 for ; Thu, 9 May 2024 00:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715215485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JCECSuU7J6QeMKE6VZnTqJFvbM5er3eI0bKkCeMusc=; b=mttoA2Fh7zvqMj20t5t0KCwtvGiSvTVYyMUz1WZSUaWut/464y8BGHYsIWZPseNWK7dKF8 YJjkK885g94jt83ibKKDMbDsPpMk/ly2m5mucgJu/OYkFwKkS982vLJzvo9XpAJaeJU8Xa zgePKXo5CcE5YnBfCL5pucAhr4rXSn1Kc+aEHyNYKCcUZ3MJm05EHGhK9RrOo0iP3Y/d5L Xi6khOADnwRxdTLknVhRT9fxq+5Dn4eUiTawa1+mE5gTR0Dc14RPrFSdiyByTH0VP7k46B 4Vi8g0wVYUfkWxp0uiv0blZ+HfD+h8px+8BysLFG2sUqffNXNTzykVM/ZltiXw== Date: Thu, 9 May 2024 02:44:44 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240509004444.GJ6420@pb2> References: <20240508151950.28555-1-ramiro.polla@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240508151950.28555-1-ramiro.polla@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4661551545214025744==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4661551545214025744== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yQrKT5UQ88pgSlC1" Content-Disposition: inline --yQrKT5UQ88pgSlC1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 08, 2024 at 05:19:49PM +0200, Ramiro Polla wrote: > ff_init_me() was being called after ff_update_duplicate_context(), > which caused the propagation of the initialization to other thread > contexts to be delayed by one frame. >=20 > In the case of mpeg4 (or flipflop_rounding), this would make the > hpel_put functions differ between the first thread (which would be > correctly initialized) and the other threads (which would be stale > from the previous frame). > --- > libavcodec/mpegvideo_enc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) have you confirmed the actual used rounding matches after this encoder & decoder side ? if yes then this should be ok thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --yQrKT5UQ88pgSlC1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjwcdAAKCRBhHseHBAsP q8bJAKCU2BkEgxJFHtSeAA2Fo+iNLVC2OQCggOHQjBlVwt15+VY1/nwO2tThsDI= =hfSn -----END PGP SIGNATURE----- --yQrKT5UQ88pgSlC1-- --===============4661551545214025744== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4661551545214025744==--