From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 171A5492E0 for ; Wed, 8 May 2024 15:20:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 93BEC68D682; Wed, 8 May 2024 18:20:01 +0300 (EEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDD3468ABD7 for ; Wed, 8 May 2024 18:19:54 +0300 (EEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-41b79451145so33702725e9.3 for ; Wed, 08 May 2024 08:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715181593; x=1715786393; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=7xilKbLiz+sRy6OdchhCbmKbPMdWZ+zw5GnzU40CgAA=; b=Ln1S55iyEpn0xe+4aKtswd6RwatsABLVJ1fixozkXJa06CZC47eHYTplwTIGsTTVRM rxNuAetG5inw0CXdM+5bGe67/C8Bp39yf0Ys417nKp6VqmwJspeSwWsVbECraOC8ndAJ xYrgekouK8IL57T6c2Msh53MBNT6iFwrF8H96Co0vDC5gY4k77a/1LYWf8Tl79ws8p5w LS4ratzswuRYlCshEKrjcRX268Bb+SOHqfJZQ5VIwrQZPpokYZ9OlYQEjLtivN5mWSVy Yon9KThAyWCNOuJkQB5NOIww4LLLLqVDEwfCBfjBNxGee1BDI4Nhri65Yzp5Pkxq8uMe +SUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715181593; x=1715786393; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7xilKbLiz+sRy6OdchhCbmKbPMdWZ+zw5GnzU40CgAA=; b=pM28MPxuDT5zYYbHMy4U+uLM5+5/1q7cZHXqUhz016mKPGS1/xK2BNoRpdYuf98QE0 ZmeLgNZuCW7t0IO4U3IroM6KcnrOmCPL678pmTqHuUtj68ST9nRyBMfZ86th9sf8C4CM RMq2q7VYKacG7rfDoBtGVN24AUeXu49rEJglJiJEhWXqQDnilC1tTrHVWe3uTwrwZKEK 3xFDTijFXMLw3D1GpQhGjhK20Z/ItcuwD7+fPDNwczL/xXuKZoxHG27WnqzVo4vuB+rm kH9/VCPoMVN2l7B098C5ow6KdRjEsAkcxVPYFu62xtgtygC0vhBMZPkay14y9qzc3kjh xlxQ== X-Gm-Message-State: AOJu0Ywhx7r+38ahyAXzyvWtAKEWo3MyMlFCFTZCjJD0bI6vYZOMUr6S oo9o0fsnqjYCXyWYN+PCqZKdOWFs3vDg35KiRFq9I5dnl9PYCu4YvHp6hAoW X-Google-Smtp-Source: AGHT+IEkiTA924rfWbf1M5ShIWAQ7x0bbzi4VxlZPCiVmAmkH1qoo1HEieY8C6h/MErGhEC47Ln4Ng== X-Received: by 2002:a05:600c:1d0e:b0:419:f31e:267c with SMTP id 5b1f17b1804b1-41f71302ce4mr21739375e9.7.1715181593280; Wed, 08 May 2024 08:19:53 -0700 (PDT) Received: from localhost.localdomain ([87.66.43.239]) by smtp.gmail.com with ESMTPSA id o9-20020a5d47c9000000b0034d7a555047sm15562105wrc.96.2024.05.08.08.19.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 08:19:52 -0700 (PDT) From: Ramiro Polla To: ffmpeg-devel@ffmpeg.org Date: Wed, 8 May 2024 17:19:49 +0200 Message-Id: <20240508151950.28555-1-ramiro.polla@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/mpegvideo_enc: fix multi-threaded motion estimation rounding for mpeg4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ff_init_me() was being called after ff_update_duplicate_context(), which caused the propagation of the initialization to other thread contexts to be delayed by one frame. In the case of mpeg4 (or flipflop_rounding), this would make the hpel_put functions differ between the first thread (which would be correctly initialized) and the other threads (which would be stale from the previous frame). --- libavcodec/mpegvideo_enc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 2a75973ac4..b601a1a9e4 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -3623,6 +3623,9 @@ static int encode_picture(MpegEncContext *s) s->q_chroma_intra_matrix16 = s->q_intra_matrix16; } + if(ff_init_me(s)<0) + return -1; + s->mb_intra=0; //for the rate distortion & bit compare functions for(i=1; ithread_context[i], s); @@ -3630,9 +3633,6 @@ static int encode_picture(MpegEncContext *s) return ret; } - if(ff_init_me(s)<0) - return -1; - /* Estimate motion for every MB */ if(s->pict_type != AV_PICTURE_TYPE_I){ s->lambda = (s->lambda * s->me_penalty_compensation + 128) >> 8; -- 2.30.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".