From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B71F49293 for ; Tue, 7 May 2024 15:02:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D389A68D0F6; Tue, 7 May 2024 18:02:23 +0300 (EEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6342A68D518 for ; Tue, 7 May 2024 18:02:17 +0300 (EEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1ee7963db64so6164695ad.1 for ; Tue, 07 May 2024 08:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715094135; x=1715698935; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pRUVLWRj6VJrZ8WKHX3Fz6VYUJjStIU97d+lSB0XvXo=; b=ZIl3Saxj9V7BpPhVnrvX2ikWtOsxib03H3bxKVQFOe0U6VhfmsZyOqBJg93LfYfQFZ +597wexojMr9KaRL2SmHXFPtylCFnvvkET+qOmMLJdfXvWLJOQ1MlyVlM1vd3SC30WfN sg6g2cxPVCiiiLKI6f3uyUzKSP6CEuO6/h+8rqSHlLcVVYHYabFvVgHPkiceiZzNZbb9 19x/CV3C7T5xDc6Wv/PduGRh0nbfpXgUxurjS+1gwHb6SHTUzpMBXHTRVTICZhUq8/8+ rFjN4h/qf0MZHf7L3mbV90g0v3r6Tc1vEO35DHtzlLEETpoUpOvVsAH2dxTEAGdv29hg 5y5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715094135; x=1715698935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pRUVLWRj6VJrZ8WKHX3Fz6VYUJjStIU97d+lSB0XvXo=; b=HUyKh2ssKXou1zN7C/RTE8Wl6tRWpb5x8aagvCVD+DxH4OaNy4OdN+nfkIB4Pur1Sp 4O61HTlPtHkF5KRI+6Tl5SbAESr5EjUVtcVu2c7wN3ubz/5CoRqWWOfqKYdBgmu2Ydmn D/R0dolzMmldQAAEeVpH7rU4b96cbxrDEYMuPL+FHZzjuaF2goYlJr7P4QQgisKXZthh uKY9UQMLL36KIMrein32zfkn5S6H2xJHnj/3fECLLbJX+wKJzzQM/fqz6MH/ZguEgZdc l2MYXCzj0NOjiqfjT1QGk4Fb5u567MWLjeL7MiowvmnRZJKMk5Ad6izUl4o1hGugQ4AA HNQw== X-Gm-Message-State: AOJu0Yy8ksP8HIkalUCH0UY/fpwxZOXtBLk6RWkAhjuG067LJfKFBRho 4iEnlz/wvK+TrPBtwE2h+vnuSrok0pY7vIW4MQ2g2oiHiXDmlCMhMpmHuw== X-Google-Smtp-Source: AGHT+IEjiZQ89s1RoiQKR2xhl8uqXu8WlX2WWwxsTdc4k8aR0/52T15HOTztgOb3fWFCTyUKI5x7sQ== X-Received: by 2002:a17:902:fc4e:b0:1e0:c37d:cfcb with SMTP id me14-20020a170902fc4e00b001e0c37dcfcbmr17438979plb.49.1715094135062; Tue, 07 May 2024 08:02:15 -0700 (PDT) Received: from localhost.localdomain ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id kt7-20020a170903088700b001e862f0b319sm10166938plb.264.2024.05.07.08.02.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 08:02:14 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 7 May 2024 12:02:04 -0300 Message-ID: <20240507150205.2039-1-jamrial@gmail.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240507002723.1603-1-jamrial@gmail.com> References: <20240507002723.1603-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The requirement is either 8 or 16 bytes alignment, not 32. This should help finding bugs in asm implementations. Signed-off-by: James Almer --- tests/checkasm/blockdsp.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/tests/checkasm/blockdsp.c b/tests/checkasm/blockdsp.c index ab87fc8fa4..f67a38d302 100644 --- a/tests/checkasm/blockdsp.c +++ b/tests/checkasm/blockdsp.c @@ -29,11 +29,6 @@ #include "libavutil/intreadwrite.h" #include "libavutil/mem_internal.h" -typedef struct { - const char *name; - int size; -} test; - #define randomize_buffers(size) \ do { \ int i; \ @@ -58,18 +53,18 @@ do { \ } while (0) static void check_fill(BlockDSPContext *h){ - const test tests[] = { - {"fill_block_tab[0]", 16}, - {"fill_block_tab[1]", 8}, - }; - LOCAL_ALIGNED_32(uint8_t, buf0, [16 * 16]); - LOCAL_ALIGNED_32(uint8_t, buf1, [16 * 16]); + LOCAL_ALIGNED_16(uint8_t, buf0_16, [16 * 16]); + LOCAL_ALIGNED_16(uint8_t, buf1_16, [16 * 16]); + LOCAL_ALIGNED_8(uint8_t, buf0_8, [8 * 8]); + LOCAL_ALIGNED_8(uint8_t, buf1_8, [8 * 8]); - for (size_t t = 0; t < FF_ARRAY_ELEMS(tests); ++t) { - int n = tests[t].size; + for (int t = 0; t < 2; ++t) { + uint8_t *buf0 = t ? buf0_8 : buf0_16; + uint8_t *buf1 = t ? buf1_8 : buf1_16; + int n = 16 - 8 * t; declare_func(void, uint8_t *block, uint8_t value, ptrdiff_t line_size, int h); - if (check_func(h->fill_block_tab[t], "blockdsp.%s", tests[t].name)) { + if (check_func(h->fill_block_tab[t], "blockdsp.fill_block_tab[%d]", t)) { uint8_t value = rnd(); memset(buf0, 0, sizeof(*buf0) * n * n); memset(buf1, 0, sizeof(*buf0) * n * n); -- 2.45.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".