From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0D2E4A755 for ; Tue, 7 May 2024 00:10:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5280068D6EC; Tue, 7 May 2024 03:10:24 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2722168D544 for ; Tue, 7 May 2024 03:10:18 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4B1EB1C0005 for ; Tue, 7 May 2024 00:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1715040617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=43JjA1bpDXbeEUscHjfpwKQLwvhjC8eE5KP7Klih+fw=; b=BdBCo2AOq1EdxkysZ5qAx1nPcUcwcaMm0CGU+iQ5fF/2nk6jVpruIUq0hjBxM6zfb8lnfG TvxRlPYqSIEikfLmkg3lOUh+LCH8GYt8U/xCHdMKQweFAZpOa+nb3Vn4YrQ+CUPuO8fyx6 Hb1svNZ370eMjsQQ+at4hInesj7jGVIiN2Z5Vkw7Dd/UGFxAYy5CS+dZln2KfUFcuZEcoR SWtEBPGKNMwa7BAApPQav7LcrD4o8CanYI7GkTCmUDywn14YHL9/1FKFKK9ftuyB/GTADy C3RdoTUgsBKFOfYKoxPnmiWkYacho7HBaJsLXbenSHDV4BCwF4iAPylqqGNtVQ== Date: Tue, 7 May 2024 02:10:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240507001016.GD6420@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8663701198005671806==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8663701198005671806== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IljW2FX7369MsSQQ" Content-Disposition: inline --IljW2FX7369MsSQQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 06, 2024 at 11:52:24PM +0200, Andreas Rheinhardt wrote: > This check has been added in 19a0729b4cfacfd90b8ee84ab0c093ff7e397e65; > this commit added high bit-depth versions of draw_edges > and added the check to indicate that the mmx version only > supports eight bits. > Yet there is no high bit depth draw_edges function any more > since d4d186d185df98492d8935a87c5b5cf369db9748; since then, > the mmx version and the C version always behave the same, > yet said check has not been removed. This commit does so. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/x86/mpegvideoencdsp_init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/libavcodec/x86/mpegvideoencdsp_init.c b/libavcodec/x86/mpegv= ideoencdsp_init.c > index ec174b15aa..9fa7ee4824 100644 > --- a/libavcodec/x86/mpegvideoencdsp_init.c > +++ b/libavcodec/x86/mpegvideoencdsp_init.c > @@ -233,9 +233,7 @@ av_cold void ff_mpegvideoencdsp_init_x86(MpegvideoEnc= DSPContext *c, > } > c->add_8x8basis =3D add_8x8basis_mmx; > =20 > - if (avctx->bits_per_raw_sample <=3D 8) { > - c->draw_edges =3D draw_edges_mmx; > - } > + c->draw_edges =3D draw_edges_mmx; does draw_edges_mmx support >8 bit ? if not the code prior to the patch looks correct to me. and the patch removes a part of >8bit support it would be better to finish the >8bit support thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --IljW2FX7369MsSQQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjlxYAAKCRBhHseHBAsP q8qyAKCBWjKbus4YC3fnNKOI1R8cfIEehQCdEs7FX39CzGeTkgv50r3gCYjBcwA= =Mkmw -----END PGP SIGNATURE----- --IljW2FX7369MsSQQ-- --===============8663701198005671806== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8663701198005671806==--