From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 179F84A763 for ; Mon, 6 May 2024 00:59:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B2A5168D542; Mon, 6 May 2024 03:59:33 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9138368D4E1 for ; Mon, 6 May 2024 03:59:27 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E5CB8E0004 for ; Mon, 6 May 2024 00:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714957167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9VZA5stViCugISsw7wAnknnt9ntc96QXygblVCTb/xY=; b=RSCfZQRN0wCsCSZwXfeqXx20Dl+d3Tts7CkJ5t3vpiKtAmgWMZWw7EHti3HeDC1Qa4g5rJ x8WN3qvVAi4hex6io9+GYEIM//pWSQ6FlivW+A71zCk+Wgv309nHsgheqPkDcbymAx4tVg xU6XL8seoY1XkymqTGYepTDc5EdM+THj2F50pRRS69vebo0oRTKRFoitlauBUJ40g8osEA vOmD7coq4O8TR4e7QdZGgDPpW1+by8VOegLQVX8j4dRnHj/tuv14mX29huwX9m1CmVLUlV lTBedY3N9Sy0c7dY9PZ96nmjpSIpzHXiG7iJ4ibeIdtmOPFBWtZGbgeGghq2TA== Date: Mon, 6 May 2024 02:59:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240506005925.GB6420@pb2> References: <20240408164900.7685-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: Fix 1 line and one column images X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1184590936080445705==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1184590936080445705== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J60OlzzWp5NQIyFz" Content-Disposition: inline --J60OlzzWp5NQIyFz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2024 at 08:00:58PM +0200, Andreas Rheinhardt wrote: > Paul B Mahol: > > On Mon, Apr 8, 2024 at 6:49=E2=80=AFPM Michael Niedermayer > > wrote: > >=20 > >> Fixes: Ticket10952 > >> Fixes: poc21ffmpeg > >> Signed-off-by: Michael Niedermayer > >> --- > >> libavcodec/mpegvideo_enc.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > >> index d1b19178247..40844b2f682 100644 > >> --- a/libavcodec/mpegvideo_enc.c > >> +++ b/libavcodec/mpegvideo_enc.c > >> @@ -1199,8 +1199,8 @@ static int load_input_picture(MpegEncContext *s, > >> const AVFrame *pic_arg) > >> ptrdiff_t dst_stride =3D i ? s->uvlinesize : s->lines= ize; > >> int h_shift =3D i ? s->chroma_x_shift : 0; > >> int v_shift =3D i ? s->chroma_y_shift : 0; > >> - int w =3D s->width >> h_shift; > >> - int h =3D s->height >> v_shift; > >> + int w =3D -((-s->width) >> h_shift); > >> + int h =3D -((-s->height) >> v_shift); > >> const uint8_t *src =3D pic_arg->data[i]; > >> uint8_t *dst =3D pic->f->data[i]; > >> int vpad =3D 16; > >> > >=20 > > What that does? Its not same as aligned rshift macro? > >=20 >=20 > It is the same, just more complicated. And maybe with more instructions. will apply with "aligned rshift" macro thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --J60OlzzWp5NQIyFz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjgrYwAKCRBhHseHBAsP qznFAJ9QT4YEDCjM3cDGX0y7RpBubdy6CgCfbxsmcKJ0mKYCh3G/inq/7wrrQKY= =YZOi -----END PGP SIGNATURE----- --J60OlzzWp5NQIyFz-- --===============1184590936080445705== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1184590936080445705==--