From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A77449C4E for ; Sat, 4 May 2024 18:27:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08B6C68D6B6; Sat, 4 May 2024 21:27:02 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA50F68D616 for ; Sat, 4 May 2024 21:26:55 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1ABE8C0006 for ; Sat, 4 May 2024 18:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714847215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GgQCrDVV2d8EBO8HH9j9qBI/m61FeNpcAJMKxi56r4g=; b=bx6Rz2GYi2VZHMXZ8upueTaOf8/vk33Up0Wjs4SVaYzxP9aOHHDuw/DKB3a1EcMRvuV3J3 fLqBOlCgPzNbm4t7KUhHd3b4NRgsbff2G/0zkbuJXUsZJRFh/LuhsO2EDdWcknQ2OyJWM2 ShYzJY+8R23a2I9nh7GINP3a9O7bX3LYFNtXfrhYkmStqNozFHkxRIp8O3q0S8Hao5fRBt 8z9bRK9mecWs67rK21tOT7+QTWlWm4AUqZ16hp2JCepzLCk30tysLWvORvhwwPF6sDl9ep 1SzgvNnRlmyVkuITfs09ZWbgAMWWYoQbS+jSNjszVcKyKBkMoKA4jTBrIenbcw== Date: Sat, 4 May 2024 20:26:54 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240504182654.GR6420@pb2> References: <20240503215502.1509887-1-michael@niedermayer.cc> <20240503215502.1509887-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1358055409932385719==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1358055409932385719== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SQ/20VPK76Ym4XWr" Content-Disposition: inline --SQ/20VPK76Ym4XWr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi_rpuenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c > > index 7e0292533bd..c5e452957b5 100644 > > --- a/libavcodec/dovi_rpuenc.c > > +++ b/libavcodec/dovi_rpuenc.c > > @@ -57,7 +57,7 @@ int ff_dovi_configure(DOVIContext *s, AVCodecContext = *avctx) > > AVDOVIDecoderConfigurationRecord *cfg; > > const AVDOVIRpuDataHeader *hdr =3D NULL; > > const AVFrameSideData *sd; > > - int dv_profile, dv_level, bl_compat_id; > > + int dv_profile, dv_level, bl_compat_id =3D -1; > > size_t cfg_size; > > uint64_t pps; > > =20 >=20 [...] > default case is never taken); but if you do this, then you can also > remove the other "bl_compat_id =3D -1" assignments (which conveys that > everything is treated as invalid unless we found it to have a valid > compatibility id). will apply with the other bl_compat_id =3D -1 removed thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus --SQ/20VPK76Ym4XWr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjZ95AAKCRBhHseHBAsP qxG4AKCG4JdLhqFEKe4oG5J/CMvZSExUjwCgh2Kg1y+OoXEPwmPhuIDZTyF2Acs= =aU0C -----END PGP SIGNATURE----- --SQ/20VPK76Ym4XWr-- --===============1358055409932385719== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1358055409932385719==--