On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi_rpuenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c > > index 7e0292533bd..c5e452957b5 100644 > > --- a/libavcodec/dovi_rpuenc.c > > +++ b/libavcodec/dovi_rpuenc.c > > @@ -57,7 +57,7 @@ int ff_dovi_configure(DOVIContext *s, AVCodecContext *avctx) > > AVDOVIDecoderConfigurationRecord *cfg; > > const AVDOVIRpuDataHeader *hdr = NULL; > > const AVFrameSideData *sd; > > - int dv_profile, dv_level, bl_compat_id; > > + int dv_profile, dv_level, bl_compat_id = -1; > > size_t cfg_size; > > uint64_t pps; > > > [...] > default case is never taken); but if you do this, then you can also > remove the other "bl_compat_id = -1" assignments (which conveys that > everything is treated as invalid unless we found it to have a valid > compatibility id). will apply with the other bl_compat_id = -1 removed thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus